Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(cypress): Fiuu connector configuration changes #7297

Open
wants to merge 19 commits into
base: main
Choose a base branch
from

Conversation

arindam-sahoo
Copy link
Contributor

@arindam-sahoo arindam-sahoo commented Feb 18, 2025

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Description

The FIUU Connector was not functioning as expected.

Key Changes

  • Added fiuu connector configs for PaymentConfirmWithShippingCost, ZeroAuthMandate, and SaveCardConfirmAutoCaptureOffSessionWithoutBilling.
  • Added billing.email in some places in the configs where it was a required parameter.
  • Mapped error_message: "The currency not allow for the RecordType" wherever necessary.
  • Mandate Payments using PMID responds with the connector_transaction_id: null if the payment fails. So, changed the command accordingly.

Additional Changes

  • This PR modifies the API contract
  • This PR modifies the database schema
  • This PR modifies application configuration/environment variables

Motivation and Context

How did you test it?

Initial Condition
image

Current Condition
image

Checklist

  • I formatted the code cargo +nightly fmt --all
  • I addressed lints thrown by cargo clippy
  • I reviewed the submitted code
  • I added unit tests for my changes where possible

Copy link

semanticdiff-com bot commented Feb 18, 2025

Review changes with  SemanticDiff

Changed Files
File Status
  cypress-tests/cypress/support/commands.js  54% smaller
  cypress-tests/cypress/e2e/configs/Payment/Fiuu.js  4% smaller
  cypress-tests/cypress/e2e/configs/Payment/Modifiers.js  0% smaller

@arindam-sahoo arindam-sahoo self-assigned this Feb 18, 2025
@arindam-sahoo arindam-sahoo changed the title refactor(cypress): configure Fiuu connector refactor(cypress): Fiuu connector configuration changes Feb 19, 2025
@@ -229,7 +229,7 @@ export const connectorDetails = {
payment_method_data: {
card: successfulNo3DSCardDetails,
billing: {
email: "mauro.morandi@nexi.it",
email: "johndoe@gmail.com",
Copy link
Contributor Author

@arindam-sahoo arindam-sahoo Feb 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Without the billing.email, the following Response Body was yielded

{
  "error": { 
    "code": "IR_04",
    "message": "Missing required param: payment_method_data.billing.email",
    "type": "invalid_request"
  }
}

@arindam-sahoo arindam-sahoo marked this pull request as ready for review February 20, 2025 07:58
@arindam-sahoo arindam-sahoo requested a review from a team as a code owner February 20, 2025 07:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CYPRESS] Fiuu Connector Configuration and Payment Processing Issues
1 participant