feat(main): notification message #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ty for your contribution. I was a little absent lately due to different things. I just want to let everyone know will check all Open issues and PR's shortly. |
jvgrootveld
requested changes
Jul 31, 2024
There was a problem hiding this comment.
@CMOISDEAD I reviewed your PR, good change!
To merge this feature asap I would recommend to change the PR so that the only change is the print to vim.notify without all the formatting changes.
I could just change it myself but I want to give you the choice to be added as a contributor 😄
|
Sorry for the late reply! Here's the update you asked for 😄 |
|
Oh right, I removed that unnecessary identation :) |
jvgrootveld
approved these changes
Aug 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed the way in which the user is informed that the directory has changed to
vim.notify