-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add path_display
support with a default value
#24
base: main
Are you sure you want to change the base?
Conversation
Move `replace_home_with_tilde` and `filename_highlight` into `path_display`. Change `previewer` opt.
…viewer` opt Fix truncate for path_display via `opts.__prefix`.
Ty for your contribution. I was a little absent lately due to different things. I just want to let everyone know will check all Open issues and PR's shortly. |
Sorry for the mess about commit history. I'm new to GitHub and didn't know new commits will be associated with this PR... About 2 newer commits, I just made the same mistake as I did a few days ago, forgot that set In this PR, I think there should be a way for user to disable previewer. How about revert to this commit which use Sorry for the mess again. I'd like to recreate a PR using a new branch if you think that's better. |
I just found out that setting |
@qw457812 Haha no problem. I use git more than a decade now, and still learn new things (or make stupid mistakes). Your PR is quite the change. I see that some ideas are also addressed in the open PR's #16, #19 and #20. I just reviewed all of those and if you don't mind I will wait for those to be updated with my comments and merged. After that I want to discuss your ideas for new and updated features. To explain a little of why new changes are going into this PR: You made a PR from a copy branch on your account (fork) which basically says "I want to merge the changes on my copy to you". If you add new changes to your copy (commits), those also reflects in the PR because you want to merge a branch into this. Not one single commit. Easier is to create a new feature/bugfix branch on your main fork which should contain only the changes you want to merge back. |
@jvgrootveld Thanks for the explanation and welcome back! I don't mind at all, looking forward to discussing with you. My starting point for this PR is that I want make the path shorter to see whole file name. Then curious about why The |
- get `~/.` if the path is $HOME itself - vim.uv compatibility for 0.9
path_display
to:~
to make path shorter.show_score
opt, default to true.previewer
opt, uses terminal tree previewer viaeza
/tree
, can be disabled by user viapreviewer = false
.Copied some codes from gczcn's fork, telescope-z.nvim and petobens's dotfiles.