Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for nbf (Not Before) token claim validation in V2 #81

Merged
merged 17 commits into from
Apr 8, 2017
Merged

Add support for nbf (Not Before) token claim validation in V2 #81

merged 17 commits into from
Apr 8, 2017

Conversation

abatishchev
Copy link
Member

Redoing #37

@abatishchev abatishchev mentioned this pull request Apr 3, 2017
Closed
@abatishchev
Copy link
Member Author

@jhurdlow, @nbarbettini please take a look

@abatishchev abatishchev added this to the 2.0 milestone Apr 3, 2017
@abatishchev abatishchev self-assigned this Apr 3, 2017
@abatishchev abatishchev requested a review from nbarbettini April 3, 2017 18:49
@jhurdlow
Copy link

jhurdlow commented Apr 3, 2017

Looks like the 'nbf' will never be checked if 'exp' doesn't exist. 'nbf' should still be checked in that case.

@abatishchev
Copy link
Member Author

abatishchev commented Apr 3, 2017 •
edited
Loading

Yes, I found that too (some tests failed, yay!) so I reworked that part.

abatishchev and others added 2 commits April 3, 2017 12:06
@abatishchev
Remove line break
491ab20
@abatishchev
Downgrading target framework version to .NET 3.5 (#71)
29424f7 
* Downgrading target framework version to .NET 3.5
* Bumping nuget version to 2.2.0-beta
@abatishchev
Copy link
Member Author

@jhurdlow can you please take a look once again?

abatishchev and others added 10 commits April 7, 2017 09:34
@abatishchev
Moving Base64UrlEncode/Base64UrlDecode to separate entity (#82)
448f085 
* Adding IBase64UrlEncoder implemented by JwtBase64UrlEncoder. Using it from JsonWebToken.Base64UrlEncode/Base64UrlDecode, JwtEncoder/Decoder.

*  Updating tests

* Removing Lazy<T>

* Adding IBase64UrlEncoder implemented by JwtBase64UrlEncoder. Calling it from JsonWebToken.Base64UrlEncode/Base64UrlDecode.

*  Updating tests

* Updating build script

* Rollingback package.cmd

* Update IBase64UrlEncoder.cs

Removing Encode prefix from IBase64UrlEncoder

* Removing Url prefix from IBase64UrlEncoder
@abatishchev
Adding the support of nbn claim
fec6b23
@abatishchev
Making UnixEpoch public
e26850c
@abatishchev
Fixing how int is parsed within claim
e5f0fa2
@abatishchev
Adding tests
5d51e2c
@abatishchev
Updating readmine
f0b84f1
@abatishchev
Remove line break
0d60c85
@abatishchev
Fixing rebase/merge
00bdd89
@abatishchev
Merge
2234e4c
@abatishchev
Update JWT.nuspec
14d4e8d 
Bumping minor version
@abatishchev abatishchev merged commit ac3568a into master Apr 8, 2017
@abatishchev abatishchev deleted the nbn branch April 8, 2017 04:09
abatishchev added a commit that referenced this pull request Apr 8, 2017
@abatishchev
Add support for nbf (Not Before) token claim validation in V2 (#81)
0791dd3 
* Adding support for nbn claim
* Bumping minor version
* Making UnixEpoch public
* Updating readme
@abatishchev
Copy link
Member Author

Pushed to NuGet as 2.3.0-beta. Thanks you both!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nbarbettini nbarbettini nbarbettini approved these changes

Assignees

@abatishchev abatishchev

Labels
enchantment
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@abatishchev @jhurdlow @nbarbettini