Run all server components as non-root users #414
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ncopa
requested review from
kke,
jnummelin and
mikhail-sakhnov
and removed request for
a team
Fix running konnectivity-server as non-root user `konnectivity-server` by creating a directory for the unix socket with the proper permissions. Replace path.Join with filepath.Join since we are joining file paths and not URLs. Drop github.com/pkg/errors in favor of fmt.Errorf (see k0sproject#227) Signed-off-by: Natanael Copa <ncopa@mirantis.com>
Add users for kube-controller-manager, kube-scheduler and konnectivity-server in footloose-alpine docker image so those process runs as non-root. Signed-off-by: Natanael Copa <ncopa@mirantis.com>
ncopa
force-pushed
the
fix-non-root-konnectivity
branch
from
a00b7ec to
9f45eeb
Compare
jnummelin
approved these changes
Nov 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the last bits needed for all server components to run as non-root users.
What this PR Includes