Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate from github.com/pkg/errors to the standard library error handling #227

Closed
mikhail-sakhnov opened this issue Oct 5, 2020 · 1 comment · Fixed by #826
Closed

Migrate from github.com/pkg/errors to the standard library error handling #227

mikhail-sakhnov opened this issue Oct 5, 2020 · 1 comment · Fixed by #826
Labels
chore

Comments

@mikhail-sakhnov
Copy link
Contributor

We use github.com/pkg/errors as main method to wrap errors.
Given that the library is in the maintenance only mode and for >1.13 versions it is a wrapper around stdlib, we could switch to the native library from standard library.
@ncopa
Copy link
Collaborator

ncopa commented Oct 9, 2020

Found this that may be relevant. https://itnext.io/golang-error-handling-best-practice-a36f47b0b94c

Since we don't need stack traces (I think?) it should be ok to switch the standard library.

ncopa added a commit to ncopa/k0s that referenced this issue Nov 17, 2020
@ncopa
Fix running konnectivity-server as non-root and misc cleanups
805d786 
Fix running konnectivity-server as non-root user `konnectivity-server`
by creating a directory for the unix socket with the proper permissions.

Replace path.Join with filepath.Join since we are joining file paths and
not URLs.

Drop github.com/pkg/errors in favor of fmt.Errorf (see k0sproject#227)

Signed-off-by: Natanael Copa <ncopa@mirantis.com>
@ncopa ncopa mentioned this issue Nov 17, 2020
Merged
ncopa added a commit to ncopa/k0s that referenced this issue Nov 17, 2020
@ncopa
Fix running konnectivity-server as non-root and misc cleanups
26e78c0 
Fix running konnectivity-server as non-root user `konnectivity-server`
by creating a directory for the unix socket with the proper permissions.

Replace path.Join with filepath.Join since we are joining file paths and
not URLs.

Drop github.com/pkg/errors in favor of fmt.Errorf (see k0sproject#227)

Signed-off-by: Natanael Copa <ncopa@mirantis.com>
ncopa added a commit to ncopa/k0s that referenced this issue Apr 6, 2021
@ncopa
Use fmt.Errorf everywhere for error handling
9a914e6 
Replace use of github.com/pkg/errors with standard fmt.Errorf

fixes k0sproject#227

Signed-off-by: Natanael Copa <ncopa@mirantis.com>
@ncopa ncopa mentioned this issue Apr 6, 2021
Merged
ncopa added a commit to ncopa/k0s that referenced this issue Apr 6, 2021
@ncopa
Use fmt.Errorf everywhere for error handling
5de216d 
Replace use of github.com/pkg/errors with standard fmt.Errorf

fixes k0sproject#227

Signed-off-by: Natanael Copa <ncopa@mirantis.com>
KoryKessel-Mirantis pushed a commit to KoryKessel-Mirantis/k0s that referenced this issue May 6, 2021
@ncopa @KoryKessel-Mirantis
Use fmt.Errorf everywhere for error handling
a0cd17d 
Replace use of github.com/pkg/errors with standard fmt.Errorf

fixes k0sproject#227

Signed-off-by: Natanael Copa <ncopa@mirantis.com>
s0j pushed a commit to s0j/k0s that referenced this issue Jun 24, 2022
Add an 'id' to plan command status
0d9f93f 
Adding an identifier to plan command status fixes a problem in signal node
reconciliation where multiple commands of the same name (ie. k0supdate + k0supdate)
wouldn't be possible.

This also removes the redundant 'CommandUpdateItem' struct in favor for embedding
the 'k0s' and 'airgap' update structs into the 'Command' struct. This aligns better
with the CRD structures.

This is a breaking change.

Fixes k0sproject#227

Signed-off-by: Shane Jarych <sjarych@mirantis.com>
s0j pushed a commit to s0j/k0s that referenced this issue Jun 27, 2022
Add an 'id' to plan command status
4650ad7 
Adding an identifier to plan command status fixes a problem in signal node
reconciliation where multiple commands of the same name (ie. k0supdate + k0supdate)
wouldn't be possible.

This also removes the redundant 'CommandUpdateItem' struct in favor for embedding
the 'k0s' and 'airgap' update structs into the 'Command' struct. This aligns better
with the CRD structures.

This is a breaking change.

Fixes k0sproject#227

Signed-off-by: Shane Jarych <sjarych@mirantis.com>
s0j pushed a commit to s0j/k0s that referenced this issue Jun 28, 2022
Add an 'id' to plan command status
b1ff73c 
Adding an identifier to plan command status fixes a problem in signal node
reconciliation where multiple commands of the same name (ie. k0supdate + k0supdate)
wouldn't be possible.

This also removes the redundant 'CommandUpdateItem' struct in favor for embedding
the 'k0s' and 'airgap' update structs into the 'Command' struct. This aligns better
with the CRD structures.

This is a breaking change.

Fixes k0sproject#227

Signed-off-by: Shane Jarych <sjarych@mirantis.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
chore
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use fmt.Errorf everywhere for error handling ncopa/k0s
3 participants
@ncopa @mikhail-sakhnov @jnummelin