Use fmt.Errorf everywhere for error handling #826
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replace use of github.com/pkg/errors with standard fmt.Errorf fixes k0sproject#227 Signed-off-by: Natanael Copa <ncopa@mirantis.com>
ncopa
force-pushed
the
std-error-handling
branch
from
9a914e6 to
5de216d
Compare
jasmingacic
approved these changes
Apr 6, 2021
| @@ -170,7 +169,7 @@ func (c *CmdOpts) startController() error { | |||
| LogLevel: c.Logging["etcd"], | |||
| } | |||
| default: | |||
| return errors.New(fmt.Sprintf("Invalid storage type: %s", c.ClusterConfig.Spec.Storage.Type)) | |||
| return fmt.Errorf("Invalid storage type: %s", c.ClusterConfig.Spec.Storage.Type) | |||
There was a problem hiding this comment.
I don't actually understand how the linter pass that, the errors should start with lowercase 🤔
jnummelin
approved these changes
Apr 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Fixes #227
What this PR Includes
Replace use of github.com/pkg/errors with standard fmt.Errorf