feat: unpin images from unknown oci bundles

[ricardomaraschini]

Description

after importing all bundles from the oci directory we go through all containerd images and unpin all images that were imported from bundles that no longer exist on the system.

we start now to add the following label when importing:

• k0sproject.ocibundle.paths

on this label we keep a list of all oci bundles that contain such image and we only unpin it if all the oci bundles were removed from the disk.

as now we are unpinning images based on their presence on disk we start to operate also on rename and remove fs events.

this commit also address an issue where we could leave a containerd connection opened.

Fixes #4433

Type of change

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• Documentation update

How Has This Been Tested?

• Manual test
• Auto test added

Checklist:

• My code follows the style guidelines of this project
• My commit messages are signed-off
• I have performed a self-review of my own code
• I have commented my code, particularly in hard-to-understand areas
• I have made corresponding changes to the documentation
• My changes generate no new warnings
• I have added tests that prove my fix is effective or that my feature works
• New and existing unit tests pass locally with my changes
• Any dependent changes have been merged and published in downstream modules
• I have checked my code and corrected any misspellings

[github-actions]

This pull request has merge conflicts that need to be resolved.

[twz123]

It could be easier to collect all the loaded images and return them as an array from loadAll(). Then use this array of loaded images in unpinAll() to skip the ones that are still on disk. That way, it'd be enough to have a simple marker label that's indicating that an image was originally imported by the OCI bundle importer, whose value is unused and could default to the empty string.

[ricardomaraschini]

It could be easier to collect all the loaded images and return them as an array from loadAll(). Then use this array of loaded images in unpinAll() to skip the ones that are still on disk. That way, it'd be enough to have a simple marker label that's indicating that an image was originally imported by the OCI bundle importer, whose value is unused and could default to the empty string.

Oh yeah, loadAll() should have been called loadAllAsLongAsTheyHaventBeenLoadedYet() :-) . We do not go through every file in the directory every time, we skip already imported files. In other words: I am not sure how this would make things easier or cleaner but I may be not understanding you.

[github-actions]

The PR is marked as stale since no activity has been recorded in 30 days