Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow all kine schemes to be joined except the local ones #4830

Merged
merged 2 commits into from
Aug 7, 2024

Conversation

twz123
Copy link
Member

@twz123 twz123 commented Aug 1, 2024

Description

Instead of whitelisting all the schemes, it is probably better to blacklist the ones that are known to be local. This allows for joining e.g. when external NATS storage is used via the jetstream scheme.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

How Has This Been Tested?

  • Manual test
  • Auto test added

Checklist:

  • My code follows the style guidelines of this project
  • My commit messages are signed-off
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

twz123 added 2 commits August 1, 2024 17:04
Signed-off-by: Tom Wieczorek <twieczorek@mirantis.com>
Instead of whitelisting all the schemes, it is probably better to
blacklist the ones that are known to be local. This allows for joining
e.g. when external NATS storage is used via the jetstream scheme.

Signed-off-by: Tom Wieczorek <twieczorek@mirantis.com>
@twz123 twz123 marked this pull request as ready for review August 1, 2024 16:02
@twz123 twz123 requested a review from a team as a code owner August 1, 2024 16:02
@twz123 twz123 requested review from ncopa and jnummelin August 1, 2024 16:02
@jnummelin jnummelin merged commit 00ab1ab into k0sproject:main Aug 7, 2024
83 checks passed
@twz123 twz123 deleted the isjoinable branch September 6, 2024 07:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants