Allow all kine schemes to be joined except the local ones

pkg/apis/k0s/v1beta1/storage.go

@@ -67,20 +67,11 @@ func DefaultStorageSpec() *StorageSpec {
 
 // IsJoinable returns true only if the storage config is such that another controller can join the cluster
 func (s *StorageSpec) IsJoinable() bool {
-	if s.Type == EtcdStorageType {
+	switch s.Type {
+	case EtcdStorageType:
 		return !s.Etcd.IsExternalClusterUsed()
-	}
-
-	if strings.HasPrefix(s.Kine.DataSource, "sqlite:") {
-		return false
-	}
-
-	if strings.HasPrefix(s.Kine.DataSource, "mysql:") {
-		return true
-	}
-
-	if strings.HasPrefix(s.Kine.DataSource, "postgres:") {
-		return true
+	case KineStorageType:
+		return s.Kine.IsJoinable()
 	}
 
 	return false
@@ -189,6 +180,28 @@ func DefaultKineConfig(dataDir string) *KineConfig {
 	}
 }
 
+func (k *KineConfig) IsJoinable() bool {
+	if scheme, _, found := strings.Cut(k.DataSource, ":"); found {
+		switch scheme {
+		case "", "sqlite":
+			return false
+
+		case "nats":
+			if u, err := url.Parse(k.DataSource); err == nil {
+				if q, err := url.ParseQuery(u.RawQuery); err == nil {
+					return q.Has("noEmbed")
+				}
+			}
+			return false
+
+		default:
+			return true
+		}
+	}
+
+	return false
+}
+
 // GetEndpointsAsString returns comma-separated list of external cluster endpoints if exist
 // or internal etcd address which is https://127.0.0.1:2379
 func (e *EtcdConfig) GetEndpointsAsString() string {

pkg/apis/k0s/v1beta1/storage_test.go

@@ -84,6 +84,36 @@ func TestStorageSpec_IsJoinable(t *testing.T) {
 			},
 			want: true,
 		},
+		{
+			name: "kine-jetstream",
+			storage: StorageSpec{
+				Type: "kine",
+				Kine: &KineConfig{
+					DataSource: "jetstream://",
+				},
+			},
+			want: true,
+		},
+		{
+			name: "kine-nats",
+			storage: StorageSpec{
+				Type: "kine",
+				Kine: &KineConfig{
+					DataSource: "nats://",
+				},
+			},
+			want: false,
+		},
+		{
+			name: "kine-nats-noembed",
+			storage: StorageSpec{
+				Type: "kine",
+				Kine: &KineConfig{
+					DataSource: "nats://?noEmbed",
+				},
+			},
+			want: true,
+		},
 		{
 			name: "kine-unknown",
 			storage: StorageSpec{
@@ -92,14 +122,22 @@ func TestStorageSpec_IsJoinable(t *testing.T) {
 					DataSource: "unknown://foobar",
 				},
 			},
+			want: true,
+		},
+		{
+			name: "kine-none",
+			storage: StorageSpec{
+				Type: "kine",
+				Kine: &KineConfig{
+					DataSource: "",
+				},
+			},
 			want: false,
 		},
 	}
 	for _, tt := range tests {
 		t.Run(tt.name, func(t *testing.T) {
-			if got := tt.storage.IsJoinable(); got != tt.want {
-				t.Errorf("StorageSpec.IsJoinable() = %v, want %v", got, tt.want)
-			}
+			assert.Equal(t, tt.want, tt.storage.IsJoinable())
 		})
 	}
 }