Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert to previous kubelet bind address logic #10475

Closed
wants to merge 1 commit into from

Conversation

brandond
Copy link
Member

@brandond brandond commented Jul 9, 2024

This is a backup PR, in case we can't get a change made to dynamiclistener. I would prefer to allow users to bind the kubelet to a specific IP, but that requires:


Proposed Changes

Revert to previous kubelet bind address logic

The kubelet bind address should always be a wildcard address selected based on the primary node-ip; don't pass the bind-address value through directly.

Types of Changes

bugfix

Verification

  1. Set --bind-address on a server or agent node
  2. Note that kubectl logs works properly to retrieve logs from pods on that node

Testing

Linked Issues

User-Facing Change

Fixed an issue where the --bind-address value was incorrectly passed through to the kubelet's --address flag.

Further Comments

The kubelet bind address should always be a wildcard address selected based on the primary node-ip; don't pass the bind-address value through directly

Signed-off-by: Brad Davidson <brad.davidson@rancher.com>
@brandond brandond requested a review from a team as a code owner July 9, 2024 22:19
@brandond brandond marked this pull request as draft July 9, 2024 22:26
@brandond brandond closed this Jul 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant