Allow passing a custom client-side dialer #80
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue:
Problem
Our remotedialer client needs to be able to provide a custom dialer for use when dialing connections on behalf of the server. Currently, the client dialer always uses an unconfigured
net.Dialer{}
struct, because there is no code path to callNewClientSessionWithDialer
, meaning thats.dialer
is always nil:remotedialer/session_serve.go
Lines 45 to 56 in 40afe79
remotedialer/client_dialer.go
Lines 20 to 25 in 40afe79
Solution
Add ConnectToProxyWithDialer that calls NewClientSessionWithDialer so that callers can provide a custom local dialer function.
There is no change to the existing ConnectoToProxy function signature or behavior, as the current code path also just calls
NewClientSessionWithDialer(auth, ws, nil)
CheckList