Fix to allow etcd-snapshot to use config file with flags that are only used with k3s server. #4464
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Derek Nola <derek.nola@suse.com>
Signed-off-by: Derek Nola <derek.nola@suse.com>
dereknola
force-pushed
the
k3s_etcd_config_fix
branch
from
2ed850f to
3d52dd6
Compare
briandowns
reviewed
Nov 11, 2021
Signed-off-by: Derek Nola <derek.nola@suse.com>
brandond
requested changes
Nov 11, 2021
Signed-off-by: Derek Nola <derek.nola@suse.com>
brandond
approved these changes
Nov 11, 2021
briandowns
approved these changes
Nov 11, 2021
Signed-off-by: Derek Nola <derek.nola@suse.com>
brandond
approved these changes
Nov 11, 2021
dereknola
added a commit
to dereknola/k3s
that referenced
this pull request
Nov 12, 2021
…y used with k3s server. (k3s-io#4464) * Enabled skipping of unknown flags from config in parser * Added new unit test, expanded existing Signed-off-by: Derek Nola <derek.nola@suse.com>
dereknola
added a commit
to dereknola/k3s
that referenced
this pull request
Nov 12, 2021
…y used with k3s server. (k3s-io#4464) * Enabled skipping of unknown flags from config in parser * Added new unit test, expanded existing Signed-off-by: Derek Nola <derek.nola@suse.com>
dereknola
added a commit
to dereknola/k3s
that referenced
this pull request
Nov 12, 2021
…y used with k3s server. (k3s-io#4464) * Enabled skipping of unknown flags from config in parser * Added new unit test, expanded existing Signed-off-by: Derek Nola <derek.nola@suse.com>
This was referenced Nov 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Allows
serverandetcd-snapshotto ignore flags in theconfig.yamlthat do not match their valid flags list. This does not affect command line arguments.Types of Changes
Verification
New unit test
Start k3s server with the following
config.yaml:Run
k3s etcd-snapshot saveand verify it does not fail. You should only see warnings about unknown flagsLinked Issues
#4449
User-Facing Change
Further Comments