Skip to content

Commit

Permalink
Remove "Could not get endpoints data" error logging (#365)
Browse files Browse the repository at this point in the history
* Remove "Could not get endpoints data" error logging as it causes no action to be taken

* Get EndpointStatus only from started pods, fixes #368

(cherry picked from commit da9d6c2)
  • Loading branch information
burmanm committed Jul 18, 2022
1 parent 3433324 commit ea143a9
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
2 changes: 2 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,8 @@ Changelog for Cass Operator, new PRs should update the `main / unreleased` secti

* [BUGFIX] [#355](https://github.com/k8ssandra/cass-operator/issues/335) Cleanse label values derived from cluster name, which can contain illegal chars.
* [BUGFIX] [#330](https://github.com/k8ssandra/cass-operator/issues/330) Apply correct updates to Service labels and annotations through additionalServiceConfig (they are now validated and don't allow reserved prefixes).
* [BUGFIX] [#368](https://github.com/k8ssandra/cass-operator/issues/368) Do not fetch endpointStatus from pods that have not started
* [BUGFIX] [#364](https://github.com/k8ssandra/cass-operator/issues/364) Do not log any errors if we fail to get endpoint states from nodes.

## v1.10.4

Expand Down
4 changes: 1 addition & 3 deletions pkg/reconciliation/reconcile_racks.go
Original file line number Diff line number Diff line change
Expand Up @@ -992,7 +992,7 @@ func (rc *ReconciliationContext) UpdateCassandraNodeStatus(force bool) error {
dc.Status.NodeStatuses = map[string]api.CassandraNodeStatus{}
}

for _, pod := range rc.dcPods {
for _, pod := range ListAllStartedPods(rc.dcPods) {
nodeStatus, ok := dc.Status.NodeStatuses[pod.Name]
if !ok {
nodeStatus = api.CassandraNodeStatus{}
Expand All @@ -1018,8 +1018,6 @@ func (rc *ReconciliationContext) UpdateCassandraNodeStatus(force bool) error {
if nodeStatus.HostID == "" {
logger.Info("Failed to find host ID", "pod", pod.Name)
}
} else {
rc.ReqLogger.Error(err, "Could not get endpoints data")
}
}
}
Expand Down

0 comments on commit ea143a9

Please sign in to comment.