Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove "Could not get endpoints data" error logging #365

Merged
merged 3 commits into from
Jul 15, 2022

Conversation

burmanm
Copy link
Contributor

@burmanm burmanm commented Jul 11, 2022

…ction to be taken

What this PR does:
Remove the entire "Could not get endpoint data" logging as it is a logging statement which requires no action to be taken by the operator or by the user. It simply spams the logs for no real reason.

Which issue(s) this PR fixes:
Fixes #364
Fixes #368

Checklist

  • Changes manually tested
  • Automated Tests added/updated
  • Documentation added/updated
  • CHANGELOG.md updated (not required for documentation PRs)
  • CLA Signed: DataStax CLA

@burmanm burmanm requested a review from a team as a code owner July 11, 2022 14:29
@jsanda
Copy link
Contributor

jsanda commented Jul 11, 2022

Do you think it could be useful for debug logging?

@burmanm
Copy link
Contributor Author

burmanm commented Jul 13, 2022

Not this line, no. It could tell that cass-operator can't connect anywhere, but we would never catch that in the debug mode.

@burmanm burmanm merged commit da9d6c2 into k8ssandra:master Jul 15, 2022
burmanm added a commit that referenced this pull request Jul 18, 2022
* Remove "Could not get endpoints data" error logging as it causes no action to be taken

* Get EndpointStatus only from started pods, fixes #368

(cherry picked from commit da9d6c2)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants