Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WFLY-17137] MicroProfile with Jakarta EE10 #1

Closed
wants to merge 1 commit into from

Conversation

kabir
Copy link
Owner

@kabir kabir commented Oct 12, 2022


* All components will be upgraded to the latest micro versions of versions of the Eclipse Microprofile specification jars, as well as the SmallRye jars and dependencies needed to implement each version, as indicated in the table in the link:#overview[Overview].
** Upgrading the components will provide the latest TCKs
* The MicroProfile Metrics subsystem will be converted to 'legacy mode', containing a `migrate` operation to remove it.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove it or migrate it to Micrometer or MP Telemetry?

Also, I've forgotten if we have any other cases of a 'migrate' op that is nothing more than a self-remove. If not, let's not introduce that concept just for this, at least not without a broader discussion (i.e. not just people interested in this work.)

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We do have other ones that migrate, but whether that is doable or not is best left to @jasondlee

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll have to research that operation before I can make an intelligent comment here. :)

microprofile/WFLY-17137-microprofile-jakarta-ee-10.adoc Outdated Show resolved Hide resolved
microprofile/WFLY-17137-microprofile-jakarta-ee-10.adoc Outdated Show resolved Hide resolved

|===

TODO: More about MP Telemetry - will we support it? If we are not that needs to be pointed out. If we are we need links to its RFE.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

MicroProfile Telemetry Tracing https://github.com/eclipse/microprofile-telemetry/tree/main/tracing is really more or less a wrapper around OTel Tracing. No API to implement. So if we have OTel integration it should be straightforward. cc/ @jasondlee

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In theory, yes. I have not looked at the state of that spec recently, but adding support for it should be fairly simple.


=== Related Issues

* https://issues.redhat.com/browse/WFLY-17138[WFLY-17138] - Convert MP Metrics subsystem to Legacy Mode

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One more thing that comes to mind is how to handle the base metrics subsystem if we drop MP metrics. Should it have similar capabilities as Micrometer now?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is more a topic for wildfly#445.

Currently the Micrometer subsystem exposes JVM metrics and also WF management API metrics, the latter in a manner very similar to the base metrics subsystem.

microprofile/WFLY-17137-microprofile-jakarta-ee-10.adoc Outdated Show resolved Hide resolved
@kabir kabir force-pushed the WFLY-17137-jakarta-ee10 branch 2 times, most recently from 936218a to aad82e9 Compare October 19, 2022 16:40
@kabir kabir force-pushed the WFLY-17137-jakarta-ee10 branch from aad82e9 to 088545a Compare October 19, 2022 16:44
@kabir kabir closed this Oct 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants