[WFLY-14947] Create analysis doc for Micrometer Support #445
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasondlee
force-pushed
the
WFLY-14947
branch
from
91a9e22 to
fd91ca0
Compare
jasondlee
force-pushed
the
WFLY-14947
branch
from
fd91ca0 to
8e0edb4
Compare
bstansberry
reviewed
Sep 26, 2022
| * RBAC support for server/jvm metrics | ||
| * Remove base/vendor prefixes (in accordance with Prometheus standards) | ||
| * This subsystem will replace the existing WildFly Metrics subsystem. Documentation will be provided describing the change. | ||
| * If MicroProfile Metrics is enabled, this subsystem will decline to install itself, as is the current behavior of WildFly Metrics. |
There was a problem hiding this comment.
@jasondlee We need migration requirements for the existing WildFly Metrics subsystem.
Either:
- It continues to work but there is appropriate logic to deal with the case where both it and the Micrometer subsystem are in a non-admin-only server config.
- It becomes a model-only / admin-only subsystem with a migrate op added to migrate to the new subsystem.
There was a problem hiding this comment.
I've update the language here a bit, but I'm not entirely sure what more you're looking for if this is insufficient.
bstansberry
reviewed
Sep 26, 2022
observability/WFLY-14947-Implement_observability_policy_metrics.adoc
Outdated
Show resolved
Hide resolved
bstansberry
reviewed
Sep 26, 2022
observability/WFLY-14947-Implement_observability_policy_metrics.adoc
Outdated
Show resolved
Hide resolved
jasondlee
force-pushed
the
WFLY-14947
branch
from
8e0edb4 to
5840c64
Compare
bstansberry
reviewed
Feb 1, 2023
| * https://issues.redhat.com/browse/WFLY-14947 | ||
|
|
||
| === Related Issues | ||
| * https://issues.redhat.com/browse7-1686 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.redhat.com/browse/WFLY-14947
Create analysis doc