Only pkg fix esm in node #2
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👋 Hi! Thank you for this contribution! Just to let you know, our GitHub SDK team does a round of issue and PR reviews twice a week, every Monday and Friday! We have a process in place for prioritizing and responding to your input. Because you are a part of this community please feel free to comment, add to, or pick up any issues/PRs that are labled with |
kachick
force-pushed
the
only-pkg-fix-esm-in-node
branch
from
3e08cd6
to
db935c7
Compare
kachick
force-pushed
the
only-pkg-fix-esm-in-node
branch
from
db935c7
to
944f9f1
Compare
kachick
force-pushed
the
only-pkg-fix-esm-in-node
branch
from
944f9f1
to
9a89b4f
Compare
kachick
added a commit
to kachick/wait-other-jobs
that referenced
this pull request
Mar 5, 2024
|
Now reported in upstream: octokit#177 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow octokit#175
To fix kachick/wait-other-jobs#717
pkg only included from #1
Because they generate pkg directory and publish in npm, but it does not exists in web.
And npm dependencies with path specifier only works for local files, not for git/github url