fix(controller): don't fail entire call to list agents based on results for one/more agents #673
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, every agent must exist in both Kubernetes and the database for this call to succeed. Thus, if for whatever reason an agent fails to reconcile on creation, any calls to this endpoint will fail. This, in turn, breaks all agents in the UI. This solution is a bit of a hack/workaround, and I do think issues should be surfaced; however, it at least ensures that the UI stays functional in this scenario for the time being.