Skip to content

fix(controller): don't fail entire call to list agents based on results for one/more agents #673

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
onematchfox wants to merge 1 commit into from
Closed

fix(controller): don't fail entire call to list agents based on results for one/more agents #673

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions go/internal/httpserver/handlers/agents.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,8 +46,11 @@ func (h *AgentsHandler) HandleListAgents(w ErrorResponseWriter, r *http.Request)

agent, err := h.DatabaseService.GetAgent(teamRef)
if err != nil {
w.RespondWithError(errors.NewNotFoundError("Agent not found", err))
return
// TODO: Rather than excluding the agent completely we should
// probably return it but mark it as "unhealthy" in some way so this
// is visible to callers (e.g. in the UI)
log.Error(err, "failed to load agent from database", "agent", teamRef)
Copy link

Copilot AI Jul 31, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The error logging should include more context about the specific error type to help with debugging. Consider logging the error type or checking if it's a specific type of error (e.g., not found vs connection error) before deciding to continue.

Suggested change
log.Error(err, "failed to load agent from database", "agent", teamRef)
if k8serrors.IsNotFound(err) {
log.Error(err, "agent not found in database", "agent", teamRef)
} else if strings.Contains(err.Error(), "connection") {
log.Error(err, "database connection error while loading agent", "agent", teamRef)
} else {
log.Error(err, "unexpected error while loading agent from database", "agent", teamRef)
}

Copilot uses AI. Check for mistakes.
continue
}

agentResponse, err := h.getAgentResponse(r.Context(), log, &team, agent)
Expand Down