KAgent Install Profile Feature #796

inFocus7 · 2025-08-21T22:16:18Z

Changes

Support "profiles" through values files with default settings. At the moment, these are just for setting up which agents to install into cluster.

demo: Installs all agents, as done now.
minimal (default): Installs no agent.

I created both explicitly in case we change defaults are anything happens, where these profiles should still act the same.

Profiles are not bundled with helm and are stored alongside the CLI code in go to be embedded. They can still be referenced through helm installations by providing the yaml filepath.

Breaking/Changed Defaults

IMPORTANT: With these changes, the additional agents are not installed by default. Useers would either need to helm [...] -f <raw-gh-path-to-demo-file> or kagent install --profile demo to install.

Testing

Helm Installation

# install kagent crds (note this also installs the kmcp ones
helm install kagent-crds ./helm/kagent-crds/  --namespace kagent

helm install kagent ./helm/kagent/ --namespace kagent --set providers.default=openAI --set providers.openAI.apiKey=$OPENAI_API_KEY -f ./go/cli/internal/profiles/demo.yaml # or minimal.yaml, or none for the default (no agents)

CLI Installation

Build

make create-kind-cluster helm-install build-cli-local

Uninstall current kagent installation

./go/bin/kagent-local uninstall

Install, non-interactive

KAGENT_HELM_REPO=./helm/ ./go/bin/kagent-local install --profile <demo|minimal>

Uninstall current kagent installation

./go/bin/kagent-local uninstall

Install, interactive

KAGENT_HELM_REPO=./helm/ ./go/bin/kagent-local

Then choose a profile from the profile selection and see installed pods.

Notes

I was looking into Istio's profile implementation, but this may not be possible on our end because of us importing the agents as subchart dependencies in Chart.yaml. Afaik, Chart.yaml is processed before templates, so --set profile=x would not work. Doing a -f <path>/<profile>.yaml does work as it's not a template, and the values would process before the Chart.

Resolves: #766

(not an implementation of the exact request flag, but the concluded method to handle this issue)

go/cli/internal/cli/install.go

inFocus7 · 2025-08-22T15:03:08Z

something's broken with my signing, i use -S + set the signing key yesterday, but still fails DCO :rip:

Copilot

Pull Request Overview

Introduces a profile system for KAgent installations that allows users to select predefined configurations for which agents to install. The change sets the default installation to minimal (no agents) and provides demo and minimal profiles via YAML files.

Changes default installation behavior from enabling all agents to enabling none
Adds profile support through values files for demo and minimal configurations
Updates CLI to support profile selection both interactively and via command-line flags

Reviewed Changes

Copilot reviewed 8 out of 8 changed files in this pull request and generated 5 comments.

Show a summary per file

File	Description
helm/kagent/values.yaml	Changes default agent configurations from enabled to disabled
helm/kagent/files/profiles/minimal.yaml	Adds minimal profile with all agents disabled
helm/kagent/files/profiles/demo.yaml	Adds demo profile with all agents enabled
helm/kagent/files/profiles/README.md	Documents the profile system and available profiles
helm/README.md	Updates documentation with profile usage examples
go/cli/internal/cli/install.go	Implements profile support in CLI installation logic
go/cli/internal/cli/const.go	Adds profile URL configuration constants
go/cli/cmd/kagent/main.go	Adds profile flag to install command and interactive selection

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

helm/kagent/files/profiles/README.md

go/cli/internal/cli/install.go

go/cli/internal/cli/const.go

inFocus7 · 2025-08-22T17:45:51Z

go/cli/internal/cli/install.go

+	// If a profile is provided, write the embedded YAML to a temp file and pass its path
+	var tmpProfilePath string
+	if profile != "" {
+		profileYAML := profiles.GetProfile(profile)


converted back to a file, because the values are defined in Helm, and in order to properly unmarshal (to a non-generic interface{}) we'd need to redefine the values in a go struct, which could lead to drift + needing to keep both in sync.

inFocus7 · 2025-08-22T17:47:05Z

helm/README.md

 ### Using Helm

 ```bash
-helm install kmcp-crds oci://ghcr.io/kagent-dev/kmcp/helm/kmcp-crds --version 0.1.2 --namespace kagent


we no longer need to install kmcp-crds separately

EItanya · 2025-08-25T16:17:16Z

go/cli/internal/cli/install.go

+				_ = tmpFile.Close()
+				_ = os.Remove(tmpFile.Name())
+				return "", fmt.Errorf("failed writing temp profile file: %w", err)
+			}
+			if err := tmpFile.Close(); err != nil {
+				_ = os.Remove(tmpFile.Name())
+				return "", fmt.Errorf("failed closing temp profile file: %w", err)


Can you just do a defer close/remove?

Also, I believe helm supports passing the values yaml as a string, so that may be easier than saving a file.

I couldn't find any docs on doing it inline through a parameter, but since it's a shell command we can pipe/input it as below (tested locally):

<yaml content> | helm ... -f -

so the logic becomes:

cmd := exec.CommandContext(ctx, "helm", args...) // If a profile is provided, pass the embedded YAML to the stdin of the helm command. // This must be the last set of arguments. if profile != "" { profileYAML := profiles.GetProfile(profile) cmd.Stdin = strings.NewReader(profileYAML) cmd.Args = append(cmd.Args, "-f", "-") } // execute, etc.

go/cli/internal/cli/install.go

EItanya · 2025-08-25T16:21:53Z

helm/kagent/values.yaml

I don't think we can do this yet :(.

I don't want such a big change/break mid-release. I would like to potentially wait until 0.7.0, or at least bring it up in the community meeting first

Darn 💔

Although, if we're alright with this approach (after resolving review comments), we could keep this non-breaking by

Revert agent defaults back to true.

Remove demo profile.

Keep the minimal profile for users who want to easily opt-out of the additional agents.

Then in the future (i.e. 0.7.0) we could update agent defaults to false and re-add demo profile. (or we keep both right now, and just revert agents back to true).

I'm not against not merging this though 👍🏼

I think keep them both for now and just revert the actual values file back to true. Having both profiles creates a good starting point for us to move forward with, even if the demo one is a tad redundant right this minute

EItanya · 2025-08-25T16:22:23Z

go/cli/internal/cli/install.go

+type helmConfig struct {
+	registry string
+	version  string
+	values   []string


Could put profile in here as well

Did it. I named it inlineValues to keep the naming generic, even though at the moment it's for holding the profile values (if one is chosen).

Signed-off-by: Fabian Gonzalez <fabian.gonzalez@solo.io>

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: Fabian Gonzalez <fabiangonz98@gmail.com> Signed-off-by: Fabian Gonzalez <fabian.gonzalez@solo.io>

Signed-off-by: Fabian Gonzalez <fabian.gonzalez@solo.io>

…ne in CLI installation, set up profile in helmConfig Signed-off-by: Fabian Gonzalez <fabian.gonzalez@solo.io>

Signed-off-by: Eitan Yarmush <eitan.yarmush@solo.io> Signed-off-by: Fabian Gonzalez <fabian.gonzalez@solo.io>

- go dir structure: move controller folder under pkg and internal - remove webhook: we don't have it anyway Signed-off-by: Fabian Gonzalez <fabian.gonzalez@solo.io>

upgrading all libs from PRs - kagent-dev#787, kagent-dev#788, kagent-dev#777, kagent-dev#776 Signed-off-by: Peter Jausovec <peter.jausovec@solo.io> Signed-off-by: Fabian Gonzalez <fabian.gonzalez@solo.io>

- grab user from x-user-id header instead. - added debug ability to run kagent + agent locally. - added observed generation to conditions, fix agent text from mcp sever reconciler --------- Signed-off-by: Yuval Kohavi <yuval.kohavi@gmail.com> Signed-off-by: Fabian Gonzalez <fabian.gonzalez@solo.io>

Signed-off-by: Eitan Yarmush <eitan.yarmush@solo.io> Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: Fabian Gonzalez <fabian.gonzalez@solo.io>

`kagent install` would construct an invalid `helm upgrade` command due to a missing `--set` parameter. When invoking `kagent install` (with no specified config params or other `kagent` env vars) & running a `ps aux` in parallel I can see that `kagent` runs the following command ```go helm upgrade --install kagent oci://ghcr.io/kagent-dev/kagent/helm/kagent --version 0.6.3 --namespace kagent --create-namespace --wait --history-max 2 --timeout 5m --set providers.default=openAI --set providers.openAI.apiKey=<REDACTED> --set ` ``` This command is invalid and errors with `Error: flag needs an argument: --set`. The reason that we pass `[]{""}` to `installChart()` is because we obtain the values from [here](https://github.com/kagent-dev/kagent/blob/main/go/cli/internal/cli/install.go#L78): ```go helmExtraArgs := GetEnvVarWithDefault(KAGENT_HELM_EXTRA_ARGS, "") ``` where if `KAGENT_HELM_EXTRA_ARGS` is not present we return `""`. This PR simply checks if the value is `!= ""` before appending to `helm upgrade` Signed-off-by: Tom Morelly <tom.morelly@clearroute.io>

Signed-off-by: Fabian Gonzalez <fabian.gonzalez@solo.io>

inFocus7 · 2025-08-25T17:46:03Z

had merge conflicts.
fixed merge conflicts.
needed to rebase for signing.
rebased.
hit the exact same merge conflicts.
fixed merge conflicts.
Pushed rebase with signing.
loop back to 1

now with 500+ unrelated changes...

inFocus7 · 2025-08-25T17:50:33Z

merge conflicts, rebasing, and signing got this PR in a broken state.

Signed-off-by: Fabian Gonzalez <fabian.gonzalez@solo.io>

original pr (which got in a terrible state due to merge conflicts + rebasing, so better to start fresh): #796 --- Originally, when listing the agents, if a single agent failed (i.e. `modelConfig` is invalid), no Agents were shown. # Changes With these changes, we: 1. Add a new AgentResponse field `Accepted` (i.e. `Reconciled`, but front-end friendly name) - This is based on the `Accepted` state of the Agent. 2. **Don't** return an error response _to the frontend_ when an Agent (or multiple) had failures. - We now continue listing agents, making the UI usable for valid agents, and adding a `Not Accepted` (could also be `Not Reconciled`, or `Error` for simplest terms) status on broken agents -- similar to how we do `Not Ready` while they are being deployed. 3. No longer display unready/un-accepted Agents in the agent sidebar from chats. ## Alternative Approaches Another approach would be to avoid returning the not-reconciled agent altogether. This would avoid needing to set up the new response field and UI changes. I was originally leaning towards that one, but figured it may be useful/quicker for users to notice any broken agents if they appear in the UI with their failed status. Another idea I had, but would probably be overkill and could constitute as a new feature, is to have a "notification system", where we would _not_ display failed agents in the agents list, but instead have the reconciliation as a notification. # Testing ## Dashboard Build & run ```sh make create-kind-cluster helm-install build-cli-local KAGENT_HELM_REPO=./helm/ ./go/bin/kagent-local dashboard ``` Update an Agent to have an invalid `modelConfig` ```sh kubectl patch agents.kagent.dev/k8s-agent -n kagent --type='json' -p='[{"op": "replace", "path": "/spec/declarative/modelConfig", "value": "default-model-config-2"}]' ``` Reload page. View listing UI to see the failed state (Not Accepted). Fix the agent. ```sh kubectl patch agents.kagent.dev/k8s-agent -n kagent --type='json' -p='[{"op": "replace", "path": "/spec/declarative/modelConfig", "value": "default-model-config"}]' ``` Reload page. It’s all good again! ## CLI This would ideally also get tested through the CLI to test the behavior of `KAGENT_HELM_REPO=./helm/ ./go/bin/kagent-local get agent`, _but_ I’m hitting “userID is required” issues. My `$HOME/.kagent/config.yaml` file has it defined, so I'm not sure of the exact issue yet. --- Resolves: #797 --------- Signed-off-by: Fabian Gonzalez <fabian.gonzalez@solo.io>

original pr (which got in a terrible state due to merge conflicts + rebasing, so better to start fresh): kagent-dev#796 --- Originally, when listing the agents, if a single agent failed (i.e. `modelConfig` is invalid), no Agents were shown. # Changes With these changes, we: 1. Add a new AgentResponse field `Accepted` (i.e. `Reconciled`, but front-end friendly name) - This is based on the `Accepted` state of the Agent. 2. **Don't** return an error response _to the frontend_ when an Agent (or multiple) had failures. - We now continue listing agents, making the UI usable for valid agents, and adding a `Not Accepted` (could also be `Not Reconciled`, or `Error` for simplest terms) status on broken agents -- similar to how we do `Not Ready` while they are being deployed. 3. No longer display unready/un-accepted Agents in the agent sidebar from chats. ## Alternative Approaches Another approach would be to avoid returning the not-reconciled agent altogether. This would avoid needing to set up the new response field and UI changes. I was originally leaning towards that one, but figured it may be useful/quicker for users to notice any broken agents if they appear in the UI with their failed status. Another idea I had, but would probably be overkill and could constitute as a new feature, is to have a "notification system", where we would _not_ display failed agents in the agents list, but instead have the reconciliation as a notification. # Testing ## Dashboard Build & run ```sh make create-kind-cluster helm-install build-cli-local KAGENT_HELM_REPO=./helm/ ./go/bin/kagent-local dashboard ``` Update an Agent to have an invalid `modelConfig` ```sh kubectl patch agents.kagent.dev/k8s-agent -n kagent --type='json' -p='[{"op": "replace", "path": "/spec/declarative/modelConfig", "value": "default-model-config-2"}]' ``` Reload page. View listing UI to see the failed state (Not Accepted). Fix the agent. ```sh kubectl patch agents.kagent.dev/k8s-agent -n kagent --type='json' -p='[{"op": "replace", "path": "/spec/declarative/modelConfig", "value": "default-model-config"}]' ``` Reload page. It’s all good again! ## CLI This would ideally also get tested through the CLI to test the behavior of `KAGENT_HELM_REPO=./helm/ ./go/bin/kagent-local get agent`, _but_ I’m hitting “userID is required” issues. My `$HOME/.kagent/config.yaml` file has it defined, so I'm not sure of the exact issue yet. --- Resolves: kagent-dev#797 --------- Signed-off-by: Fabian Gonzalez <fabian.gonzalez@solo.io>

This comment was marked as outdated.

Sign in to view

inFocus7 force-pushed the feat/add-kagent-installation-profiles branch 2 times, most recently from 08ca93c to 6292660 Compare August 22, 2025 14:40

inFocus7 commented Aug 22, 2025

View reviewed changes

go/cli/internal/cli/install.go Show resolved Hide resolved

inFocus7 force-pushed the feat/add-kagent-installation-profiles branch 2 times, most recently from b1cf0e5 to eeed096 Compare August 22, 2025 16:21

inFocus7 marked this pull request as ready for review August 22, 2025 16:21

Copilot AI review requested due to automatic review settings August 22, 2025 16:21

inFocus7 requested review from EItanya, ilackarms and yuval-k as code owners August 22, 2025 16:21

Copilot AI reviewed Aug 22, 2025

View reviewed changes

inFocus7 force-pushed the feat/add-kagent-installation-profiles branch from a5268bf to 917566d Compare August 22, 2025 17:43

inFocus7 commented Aug 22, 2025

View reviewed changes

EItanya reviewed Aug 25, 2025

View reviewed changes

go/cli/internal/cli/install.go Show resolved Hide resolved

EItanya reviewed Aug 25, 2025

View reviewed changes

inFocus7 and others added 10 commits August 25, 2025 13:43

add possible approaches to installment profile feature

489f5b2

Signed-off-by: Fabian Gonzalez <fabian.gonzalez@solo.io>

set up profile values file

b928653

Signed-off-by: Fabian Gonzalez <fabian.gonzalez@solo.io>

set up profile installation commands

1868773

Signed-off-by: Fabian Gonzalez <fabian.gonzalez@solo.io>

re-add newline to avoid wrong gitdiff

2cb44db

Signed-off-by: Fabian Gonzalez <fabian.gonzalez@solo.io>

update helm/README.md

8ff48d3

Signed-off-by: Fabian Gonzalez <fabian.gonzalez@solo.io>

DRY installation code for interactive + non-interactive mode

bdb9864

Signed-off-by: Fabian Gonzalez <fabian.gonzalez@solo.io>

add readme for profiles

9d9cffa

Signed-off-by: Fabian Gonzalez <fabian.gonzalez@solo.io>

Apply suggestions from code review

1ddee2d

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: Fabian Gonzalez <fabiangonz98@gmail.com> Signed-off-by: Fabian Gonzalez <fabian.gonzalez@solo.io>

move profiles to be embedded in CLI

1f2af57

Signed-off-by: Fabian Gonzalez <fabian.gonzalez@solo.io>

revert agent installation default to enabled, add profile values inli…

0d668dd

…ne in CLI installation, set up profile in helmConfig Signed-off-by: Fabian Gonzalez <fabian.gonzalez@solo.io>

EItanya and others added 7 commits August 25, 2025 13:43

feat: introduce golangci-lint (kagent-dev#794)

ead5d59

Signed-off-by: Eitan Yarmush <eitan.yarmush@solo.io> Signed-off-by: Fabian Gonzalez <fabian.gonzalez@solo.io>

cleanup: go folder (kagent-dev#795)

48702d9

- go dir structure: move controller folder under pkg and internal - remove webhook: we don't have it anyway Signed-off-by: Fabian Gonzalez <fabian.gonzalez@solo.io>

fix snyk issues (kagent-dev#799)

1d059eb

upgrading all libs from PRs - kagent-dev#787, kagent-dev#788, kagent-dev#777, kagent-dev#776 Signed-off-by: Peter Jausovec <peter.jausovec@solo.io> Signed-off-by: Fabian Gonzalez <fabian.gonzalez@solo.io>

feat: make sse timeout configurable (kagent-dev#800)

ee7cb0b

Signed-off-by: Eitan Yarmush <eitan.yarmush@solo.io> Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: Fabian Gonzalez <fabian.gonzalez@solo.io>

remove old readme addition

d0e8162

Signed-off-by: Fabian Gonzalez <fabian.gonzalez@solo.io>

inFocus7 force-pushed the feat/add-kagent-installation-profiles branch from 76a2546 to d0e8162 Compare August 25, 2025 17:44

inFocus7 requested a review from peterj as a code owner August 25, 2025 17:44

inFocus7 closed this Aug 25, 2025

inFocus7 added a commit to inFocus7/kagent that referenced this pull request Aug 25, 2025

port code from kagent-dev#796

e6182b4

inFocus7 mentioned this pull request Aug 25, 2025

KAgent Install Profile Feature #808

Merged

inFocus7 added a commit to inFocus7/kagent that referenced this pull request Aug 25, 2025

port code from kagent-dev#796

02e409e

Signed-off-by: Fabian Gonzalez <fabian.gonzalez@solo.io>

KAgent Install Profile Feature #796

KAgent Install Profile Feature #796

Uh oh!

Conversation

inFocus7 commented Aug 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Changes

Breaking/Changed Defaults

Testing

Helm Installation

CLI Installation

Notes

Uh oh!

This comment was marked as outdated.

Uh oh!

inFocus7 commented Aug 22, 2025

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

inFocus7 Aug 25, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

inFocus7 commented Aug 25, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

inFocus7 commented Aug 25, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

inFocus7 commented Aug 21, 2025 •

edited

Loading

inFocus7 Aug 25, 2025 •

edited

Loading

inFocus7 commented Aug 25, 2025 •

edited

Loading