Skip to content

fix(install): do not add --set for an empty string #807

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
EItanya merged 1 commit into from
Aug 25, 2025
Merged

fix(install): do not add --set for an empty string #807

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions go/cli/internal/cli/install.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,9 @@ func installChart(ctx context.Context, chartName string, namespace string, regis

// Add set values if any
for _, setValue := range setValues {
args = append(args, "--set", setValue)
if setValue != "" {
args = append(args, "--set", setValue)
}
}

cmd := exec.CommandContext(ctx, "helm", args...)
Expand All @@ -45,8 +47,7 @@ func installChart(ctx context.Context, chartName string, namespace string, regis
return "", nil
}

func InstallCmd(ctx context.Context, cfg *config.Config) *PortForward {

func InstallCmd(ctx context.Context, cfg *config.Config) *PortForward {
if version.Version == "dev" {
fmt.Fprintln(os.Stderr, "Installation requires released version of kagent")
return nil
Expand Down
Loading