1448 use yip #135
Merged
1448 use yip #135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Dimitris Karakasilis <dimitris@karakasilis.me>
Signed-off-by: Dimitris Karakasilis <dimitris@karakasilis.me>
Signed-off-by: Dimitris Karakasilis <dimitris@karakasilis.me>
Signed-off-by: Dimitris Karakasilis <dimitris@spectrocloud.com>
Codecov Report
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. @@ Coverage Diff @@
## master #135 +/- ##
==========================================
+ Coverage 18.50% 19.24% +0.73%
==========================================
Files 15 14 -1
Lines 1589 1528 -61
==========================================
Hits 294 294
+ Misses 1271 1210 -61
Partials 24 24
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
to get this fix: mudler/yip#96 and stop "replacing" in go.mod. We are not 100% sure what the replacement was there for but we'll test and see. Also remove replace of elemental-cli which was there only for debugging Signed-off-by: Dimitris Karakasilis <dimitris@karakasilis.me>
mauromorales
approved these changes
Jun 30, 2023
There was a problem hiding this comment.
not totally clear what the impact of this one will be, specially regarding the bumping of yip but we had a discussion and seems like it's handled by kairos-io/kairos#1426
|
This still didnt work, probably for the mangling we do with the disk? |
Itxaka
force-pushed
the
1448-use-yip
branch
2 times, most recently
from
1c4fd1d to
962b6be
Compare
Signed-off-by: Itxaka <itxaka.garcia@spectrocloud.com>
Signed-off-by: Itxaka <itxaka.garcia@spectrocloud.com>
layour plugin needs it Signed-off-by: Itxaka <itxaka.garcia@spectrocloud.com>
Not needed for a while Signed-off-by: Itxaka <itxaka.garcia@spectrocloud.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of: kairos-io/kairos#1448
Also encorporates this fix: 34cf7b1