🐛 Merge grub yip config #1426
Merged
🐛 Merge grub yip config #1426
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With yip 1.x things can run at the same level as its now using a DAG. Problem is with the grub stuff it was 2 files trying to mount and unmount the state dir. That worked as expected before as it run one after the other but now they can run in parallel as they dont depend on each other. This PR merges both configs into one to avoid mount/umount several times and because both deal with grub stuff. Signed-off-by: Itxaka <itxaka.garcia@spectrocloud.com>
jimmykarily
approved these changes
May 18, 2023
This was referenced Jun 29, 2023
mauromorales
pushed a commit
that referenced
this pull request
Jun 30, 2023
With yip 1.x things can run at the same level as its now using a DAG. Problem is with the grub stuff it was 2 files trying to mount and unmount the state dir. That worked as expected before as it run one after the other but now they can run in parallel as they dont depend on each other. This PR merges both configs into one to avoid mount/umount several times and because both deal with grub stuff. Signed-off-by: Itxaka <itxaka.garcia@spectrocloud.com>
mauromorales
pushed a commit
that referenced
this pull request
Jun 30, 2023
With yip 1.x things can run at the same level as its now using a DAG. Problem is with the grub stuff it was 2 files trying to mount and unmount the state dir. That worked as expected before as it run one after the other but now they can run in parallel as they dont depend on each other. This PR merges both configs into one to avoid mount/umount several times and because both deal with grub stuff. Signed-off-by: Itxaka <itxaka.garcia@spectrocloud.com>
mauromorales
pushed a commit
that referenced
this pull request
Jun 30, 2023
With yip 1.x things can run at the same level as its now using a DAG. Problem is with the grub stuff it was 2 files trying to mount and unmount the state dir. That worked as expected before as it run one after the other but now they can run in parallel as they dont depend on each other. This PR merges both configs into one to avoid mount/umount several times and because both deal with grub stuff. Signed-off-by: Itxaka <itxaka.garcia@spectrocloud.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With yip 1.x things can run at the same level as its now using a DAG. Problem is with the grub stuff it was 2 files trying to mount and unmount the state dir. That worked as expected before as it run one after the other but now they can run in parallel as they dont depend on each other.
This PR merges both configs into one to avoid mount/umount several times and because both deal with grub stuff.
What this PR does / why we need it:
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #