Use logical selectors in nest. #189
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds supports for sass backref (`&`) is `LogicalSelectorSet` and introduces a new type, `CssSelectorSet`, which is guaranteed to not contain backrefs. Functions that are intended to not accept backrefs are moved to `CssSelectorSet`. The `nest` function is also created as a `CssSelectorSet` method, as the first argument may not contain backrefs. The other argument is a `LogicalSelectorSet`, though.
kaj
added a commit
that referenced
this pull request
May 19, 2024
Released 2024-05-19. Progress: 5803 of 7673 tests passed. * Improved support for the `selector.nest` function (PR #189). * Moved `selector.append` to new selector implementation (PR #190). * Implemented the `selector.simple-selectors` function (PR #191). * Implemented the `selector.extend` function, except some of the more complicated corner cases (PR #194). * Parse next-generation css selectors directly (rather than parsing as the old type and converting to the new). Fixes the `selector.parse` function and improves support for other selector functions (PR #192). * Some internal cleanup and improvements in the next-generation css selector implementation (which is currently internal and used only for selector functions, but should replace the old css selector implementation in release 0.29). * Improvements in css-compatible functions that is evaluated if possible, but kept as css if the arguments _may_ make sense in a browser (PR #193). * Improved no-args `math.random`, it now returns a f64 number. * Some other minor code cleanup. * MSRV is now 1.74 for rsass-cli (and still 1.61 for the lib and macros). * Updated sass-spec test suite to 2024-05-16.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds supports for sass backref (
&) isLogicalSelectorSetand introduces a new type,CssSelectorSet, which is guaranteed to not contain backrefs.Functions that are intended to not accept backrefs are moved to
CssSelectorSet. Thenestfunction is also created as aCssSelectorSetmethod, as the first argument may not contain backrefs. The other argument is aLogicalSelectorSet, though.