Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve css functions #193

Merged
merged 2 commits into from
May 17, 2024
Merged

Improve css functions #193

merged 2 commits into from
May 17, 2024

Conversation

kaj
Copy link
Owner

@kaj kaj commented Apr 26, 2024

Use a NumOrSpecial value type to help implement css functions that should be evaluated if possible but otherwise left as a call if it might be legal css.

(Also some minor cleanup)

@kaj kaj force-pushed the cleanup branch 7 times, most recently from 7fd0ea3 to 8b105ce Compare April 28, 2024 18:18
Mainly remove redundant `use` statements.
@kaj kaj force-pushed the cleanup branch 13 times, most recently from f0cd067 to d28d685 Compare May 3, 2024 20:33
@kaj kaj force-pushed the cleanup branch 6 times, most recently from 7e274d0 to 709126a Compare May 13, 2024 10:30
@kaj kaj force-pushed the cleanup branch 3 times, most recently from 5b019e2 to f620100 Compare May 16, 2024 17:44
@kaj kaj force-pushed the cleanup branch 4 times, most recently from f217645 to 225ec90 Compare May 16, 2024 23:00
@kaj kaj merged commit ff6f6f3 into main May 17, 2024
26 checks passed
@kaj kaj deleted the cleanup branch May 17, 2024 17:26
kaj added a commit that referenced this pull request May 19, 2024
Released 2024-05-19.
Progress: 5803 of 7673 tests passed.

* Improved support for the `selector.nest` function (PR #189).
* Moved `selector.append` to new selector implementation (PR #190).
* Implemented the `selector.simple-selectors` function (PR #191).
* Implemented the `selector.extend` function, except some of the more
  complicated corner cases (PR #194).
* Parse next-generation css selectors directly (rather than parsing as
  the old type and converting to the new).  Fixes the `selector.parse`
  function and improves support for other selector functions (PR #192).
* Some internal cleanup and improvements in the next-generation css
  selector implementation (which is currently internal and used only
  for selector functions, but should replace the old css selector
  implementation in release 0.29).
* Improvements in css-compatible functions that is evaluated if
  possible, but kept as css if the arguments _may_ make sense in a
  browser (PR #193).
* Improved no-args `math.random`, it now returns a f64 number.
* Some other minor code cleanup.
* MSRV is now 1.74 for rsass-cli (and still 1.61 for the lib and macros).
* Updated sass-spec test suite to 2024-05-16.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant