Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Default log level should probably be warn for everything #12

Closed
cynthia opened this issue Dec 5, 2018 · 2 comments
Closed

Default log level should probably be warn for everything #12

cynthia opened this issue Dec 5, 2018 · 2 comments
Milestone
0.2

Comments

@cynthia
Copy link
Contributor

cynthia commented Dec 5, 2018

For most users, the logs that come out of info level aren't very useful - in particular under Python when they can't nicely pipe it to a standard logging framework.

Would it make sense to make the default ("all", "warn") instead of info?

If the project owners agree with this I can send in a PR.
@krikit
Copy link
Member

krikit commented Dec 5, 2018

OK. Can you send us pull request?

cynthia added a commit to cynthia/khaiii that referenced this issue Dec 5, 2018
@cynthia
Make log level default to warn on CLI and Python bindings. kakao#12.
a208dca 
There is a nicer way of doing this, but the expected size of the
incision needed for that to happen is probably larger than what
can be justified for a minor change like this.
cynthia added a commit to cynthia/khaiii that referenced this issue Dec 5, 2018
@cynthia
Make log level default to warn on CLI and Python bindings. kakao#12.
f65541e 
There is a nicer way of doing this, but the expected size of the
incision needed for that to happen is probably larger than what
can be justified for a minor change like this.
@cynthia
Copy link
Contributor Author

cynthia commented Dec 5, 2018

See #14.

@krikit krikit added this to the 0.2 milestone Dec 6, 2018
@krikit krikit closed this as completed Dec 6, 2018
@krikit krikit mentioned this issue Dec 16, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.2
Development

No branches or pull requests
2 participants
@cynthia @krikit