Make log level default to warn on CLI and Python bindings. #12.

[cynthia]

There is a nicer way of doing this, but the expected size of the incision needed for that to happen is probably larger than what can be justified for a minor change like this. For those reasons, patch is done in two places.

[krikit]

Thanks for your job. But as I mentioned here at The last thing, please could you give pull request on develop branch?

[cynthia]

So, one thing I would like to mention here is that if you want pull requests to land on a specific branch you should probably make that the default branch. Otherwise Github will happily default you to master, and you'll get more patches like this.

[krikit]

As a user, I agree with master as a default branch. But for developers, I think we have to work on develop branch as default. We explained why we think pull request be merged into develop branch here. Please could you give us pull request into develop again, like #15?

If a user meets a sudden change in master branch without release note, it will be inconvenience for him/her.

[cynthia]

This is actually easier to do on your side. It’s a limitation of GH that I can’t edit the PR to land on a different branch, so I suggest you try this:

git checkout develop
git remote add cynthia https://github.com/cynthia/khaiii
git fetch —all
git pull —rebase cynthia warn-default
git push origin develop

This should get what you are asking for - and if GH is smart it should also close this PR.

[krikit]

Thank you for your effort. I merged what you explained. I had to merge local develop branch into origin develop between your step 4 and 5. At that time, I also added pull request number #14 manually on commit log. But GitHub is not so smart. :( This pull request is not closed automatically. Now I close this issue manually.

Next time you give us a pull request, please set merge branch as develop. Thank you for your effort again.

[cynthia]

Thanks! I’ve raised #17 in hope to prevent future incidents like this.