Rework of #9. #15
Merged
Rework of #9. #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes the Py3.6-isms, but will not fix cases where a string is expected to be unicode. I haven't checked if that is the case, but judging from the nature of the project the likelihood of a follow-up patch to fix that seems pretty high.
|
Thanks for your coorperation. We just have made developer's guideline. I hope it helps you why we decide to use develop branch as a default. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a reworked patch from PR #9. Changes:
'{}'.format(var)is used instead of a locals dump passed as a keyword argument.For discussion, please refer to #9.