perf(metarepos): add mrpb.StorageNodeUncommitReport pool
#425
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Current dependencies on/for this PR:
This comment was auto-generated by Graphite. |
Codecov ReportPatch coverage:
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more Additional details and impacted files@@ Coverage Diff @@
## otel_label #425 +/- ##
==============================================
+ Coverage 63.68% 63.74% +0.06%
==============================================
Files 131 131
Lines 17894 17894
==============================================
+ Hits 11395 11406 +11
+ Misses 5954 5945 -9
+ Partials 545 543 -2
... and 4 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
This patch adds an `mrpb.StorageNodeUncommitReport` pool, which is
`proto/mrpb.storageNodeUncommitReportPool`. It reduces heap objects allocated repeatedly whenever
processing reports received from storage nodes.
Below heap profiling is the previous result.
```
flat flat% sum% cum cum%
70865580 8.38% 44.73% 71293773 8.43% github.com/kakao/varlog/internal/metarepos.(*reportCollectExecutor).processReport
```
Now here it is after applying this patch.
```
flat flat% sum% cum cum%
20734504 2.10% 75.92% 42122814 4.26% github.com/kakao/varlog/internal/metarepos.(*reportCollectExecutor).processReport
```
ijsong
force-pushed
the
reuse_uncommit_report
branch
from
87e2352 to
fd4dd81
Compare
|
To stack multiple PRs linearly, I close this PR, duplicated to #446. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
This patch adds an
mrpb.StorageNodeUncommitReportpool, which isproto/mrpb.storageNodeUncommitReportPool. It reduces heap objects allocated repeatedly wheneverprocessing reports received from storage nodes.
Below heap profiling is the previous result.
Now here it is after applying this patch.