Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent Only Emoji Spam in Chat #36

Merged
merged 12 commits into from
May 18, 2023
Merged

Conversation

samithiwat
Copy link
Collaborator

@samithiwat samithiwat commented May 18, 2023

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

According to this feature request in Discord
image

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • Refactor or other

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation

@samithiwat
Copy link
Collaborator Author

Need permission for bot

  • Manage Message

@leomotors leomotors requested a review from dtinth May 18, 2023 10:51
@@ -0,0 +1,23 @@
import { Events, Message } from 'discord.js'
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix ESLint warning and should be good to go

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should make all warnings error and fail the build. otherwise, reviewers will have to keep ask people to remove warnings.

but that's out of scope for this PR.

therefore, gonna merge it for now

@leomotors
Copy link
Collaborator

@narze 🙏

@@ -0,0 +1,23 @@
import { Events, Message } from 'discord.js'
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should make all warnings error and fail the build. otherwise, reviewers will have to keep ask people to remove warnings.

but that's out of scope for this PR.

therefore, gonna merge it for now

@dtinth dtinth added this pull request to the merge queue May 18, 2023
Merged via the queue into kaogeek:main with commit ce58546 May 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants