Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: when using browserify dont create source code caching #124

Merged
merged 1 commit into from
Apr 23, 2015

Conversation

piecyk
Copy link
Contributor

@piecyk piecyk commented Jan 3, 2015

Simple check when using browserify for coverage and there is nothing in sourceCache.

Example of karma.conf.js with browserify and karma-coverage.

@peter-mouland
Copy link

+1 :)

@jasonslyvia
Copy link

Please review and merge this!

@maksimr
Copy link
Contributor

maksimr commented Mar 30, 2015

@piecyk What problem solve this PR?

P.S. Rebase changes on master

Thanks!

@maksimr
Copy link
Contributor

maksimr commented Mar 31, 2015

Seems it should fix issue #123

@unlok
Copy link

unlok commented Apr 20, 2015

Yes. It fixes the issue #123.

@piecyk @maksimr
Maybe rebase and merge?

@piecyk piecyk reopened this Apr 20, 2015
@piecyk
Copy link
Contributor Author

piecyk commented Apr 23, 2015

@maksimr it's so simple change, review it or close this, thanks

maksimr added a commit that referenced this pull request Apr 23, 2015
fix: when using browserify dont create source code caching
@maksimr maksimr merged commit 26b453e into karma-runner:master Apr 23, 2015
@maksimr
Copy link
Contributor

maksimr commented Apr 23, 2015

@piecyk Thanks!

@unlok
Copy link

unlok commented Apr 23, 2015

@piecyk @maksimr Thanks!

@maksimr, what about the release?

@khaled-su
Copy link

Thanks! this worked for me!

@jukkasi
Copy link

jukkasi commented May 11, 2015

+1

@joshfrench
Copy link

Any chance of a new release with this in place?

@dignifiedquire
Copy link
Member

If all goes well we will be cutting ne released this week. (Our release process was broken :( but is getting fixed now)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants