-
Notifications
You must be signed in to change notification settings - Fork 247
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: reporter allow using a externally provided source cachere for reporters #140
fix: reporter allow using a externally provided source cachere for reporters #140
Conversation
This pull request allows for specifying an external source cache storage in module.exports = function(config) {
config.set({
coverageReporter: {
type: "html",
sourceStore: require("istanbul").Store.create("fslookup")
}
} |
also, can someone take a look as to why the travis build failed? |
did it ? |
Travis looks happy, but this needs a rebase onto the latest master, as there are merge conflicts |
f7f8957
to
ec67e37
Compare
rebased |
Could you add some documentation about this please? |
sure |
stilll missing docs and rebase |
ec67e37
to
d0e45b9
Compare
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project, in which case you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed, please reply here (e.g.
|
I signed it! |
CLAs look good, thanks! |
|
d0e45b9
to
39a6ae0
Compare
fixed |
@weikinhuang I'm afraid I need another rebase, another merge conflict while I merged a different PR, thanks |
…porters change `coverageReporter` options to allow for specifying `sourceStore`, this is an instance of `istanbul.Store` to look up source files. This allows using external coverage collectors like `browserify-istanbul` for instrumenting code.
39a6ae0
to
9b1517f
Compare
rebased |
Thanks |
fix: reporter allow using a externally provided source cachere for reporters
change
coverageReporter
options to allow for specifyingsourceStore
, thisis an instance of
istanbul.Store
to look up source files. This allows usingexternal coverage collectors like
browserify-istanbul
for instrumenting code.references #16, #123, #124