-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(debug-runner): support asynchronous tests in the debug runner #2817
fix(debug-runner): support asynchronous tests in the debug runner #2817
Conversation
Use console.error to log errors to the console instead of throwing an error. This makes sure that errors are scoped properly for asynchronous tests, instead of showing up as uncaught errors on all asynchronous tests. Fixes #2811
Fixed the comments in the test runner related to the previous commit. Fixes #2811
The appveyor build fails with an error that seems unrelated to the changes. Is there any way to retry the build? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please remove package-lock.json
, not going to support for the time being as it is causing more issues than help.
It is not being used and is causing issues with the build.
We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for the commit author(s). If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. |
It is not being used and is causing issues with the build.
…olp/karma into fix-debugging-async-tests
What's causing the wait on the CLA check? Is there anything I can do to move this forward? |
@daanstolp not sure what the issue with that check is, merged now, thank you |
Any chance this can be a patch release? Or released in general? |
I apologize if this is the wrong channel of communication (and would greatly appreciate some feedback!): any chance this can be released as a patch? Or is this undergoing testing? |
Just wanted to add a "me too": me and my team are also eagerly awaiting the availability of this fix. When can we expect this to be released? |
Hello fellow karma maintainers! Can I get a quick update on this issue? @daanstolp Have you by chance released a scoped package for this fix? |
AFAICT this was released |
I'll check it out. Thanks for the tip! |
1 similar comment
I'll check it out. Thanks for the tip! |
It looks like it was not bundled. @dignifiedquire Have I missed something? |
Just to verify: the source does contain the fix, but the 1.7.1 npm release does not. |
This bug blocks my entire company's migration to React 16 (via inability to upgrade to Enzyme 3 which is oddly triggering this bug in a way Enzyme 2 did not). @dignifiedquire any idea when this will be released? Edit: looks like this got published in 2.0.0 a couple hours ago. It's not listed in the release notes (due to mis-tagging, I think), but it's in the source code! |
Use console.error to log errors to the console instead of throwing
an error. This makes sure that errors are scoped properly for
asynchronous tests, instead of showing up as uncaught errors on
all asynchronous tests.
Fixes #2811