Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(debug-runner): support asynchronous tests in the debug runner #2817

Merged
merged 5 commits into from
Aug 25, 2017
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
fix(debug-runner): support asynchronous tests in the debug runner
Use console.error to log errors to the console instead of throwing
an error. This makes sure that errors are scoped properly for
asynchronous tests, instead of showing up as uncaught errors on
all asynchronous tests.

Fixes #2811
daanstolp committed Aug 21, 2017
commit 437c4edbd024458dafa52769e376535a7c021c58
9,455 changes: 9,455 additions & 0 deletions package-lock.json

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion static/debug.js
Original file line number Diff line number Diff line change
@@ -18,7 +18,7 @@ window.__karma__.result = window.console ? function (result) {
// Throwing error without losing stack trace
(function (err) {
setTimeout(function () {
throw err
window.console.error(err)
})
})(result.log[i])
}