fix(html2js): handling of the backslash character #611
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is just a fix for stable, in the master I will change the implementation, so that the "testacular" is responsible for sending the coverage results, rather than individual adapters. Closes karma-runner#365
Test for undefined when passing arguments to path.resolve as node will throw an error since 0.10 otherwise.
BREAKING CHANGE: this breaks in couple of ways - whenever you call the "testacular" binary, change it to "karma", eg. `testacular start` becomes `karma start`. - if you rely on default name of the config file, change it to `karma.conf.js`. - if you access `__testacular__` object in the client code, change it to `__karma__`, eg. `window.__testacular__.files` becomes `window.__karma__.files`.
Merged from master to stable. Closes karma-runner#382 Conflicts: lib/config.js test/unit/config.spec.coffee
As it should not be required anymore...
This improves compatability with node 0.10. See karma-runner#400.
This reverts commit 7e3f192.
Now we should be compatible with both Node 0.8 and 0.10 ;-)
Fixes karma-runner#447. Conflicts: lib/config.js
Because it runs on Node 0.10
Not sure how, but somehow we forgot these...
Because the latest angular-scenario.js does not work with old AngularJS.
Since 0.6.3, log4js works on both 0.8 and 0.10 so we don't have to do this hack anymore... log4js-node/log4js-node#129
Update to the latest master (ab755a25f9ca3f3f000623071d8de3ddc4b1d78e), which contains the fix for IE issue.
If the binary does not exists: - handle the error (Node 0.10+ throws unhandled error events) - show nicer message - do not retry Closes karma-runner#452
So that the same symlink works for both stable/master branch.
This should have been part of 81b271b
Most of the browsers returns "not-normally" (because of receiving a signal) and therefore exit event gets null exit code. But PhantomJS exits "normally" with status code 1 (after receiving TERM signal). I think this logic is better - show error, if process exits during a state which does not expect exiting (CAPTURED, BEING_CAPTURED). Closes karma-runner#444
At the html2js preprocessor escape the backslash character when this is present in a template Closes karma-runner#583
|
Open to the wrong branch by mistake |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At the html2js preprocessor escape the backslash character when this is
present in a template
Closes #583