Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: deploy karmada-metreics-adapter with helm/karmadactl/karmada-operator #3626

Closed
3 tasks done
jwcesign opened this issue Jun 2, 2023 · 21 comments · Fixed by #4303
Closed
3 tasks done

feat: deploy karmada-metreics-adapter with helm/karmadactl/karmada-operator #3626

jwcesign opened this issue Jun 2, 2023 · 21 comments · Fixed by #4303
Assignees
Labels
help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/feature Categorizes issue or PR as related to a new feature.

Comments

@jwcesign
Copy link
Member

jwcesign commented Jun 2, 2023

What would you like to be added:

  • Implement deployment of karmada-metrics-adapter using Helm. @jwcesign
  • Implement deployment of karmada-metrics-adapter using karmadactl. @chaunceyjiang
  • Implement deployment of karmada-metrics-adapter using karmada-operator. @calvin0327

Why is this needed:
Provider different ways to install karmada-metrics-adapter, to utilize FederatedHPA and scale workloads across multiple clusters.

If you are interested in one of the installation methods, you can choose to complete certain tasks.

@jwcesign jwcesign added the kind/feature Categorizes issue or PR as related to a new feature. label Jun 2, 2023
@jwcesign
Copy link
Member Author

jwcesign commented Jun 2, 2023

/help

@karmada-bot
Copy link
Collaborator

@jwcesign:
This request has been marked as needing help from a contributor.

Please ensure the request meets the requirements listed here.

If this request no longer meets these requirements, the label can be removed
by commenting with the /remove-help command.

In response to this:

/help

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@karmada-bot karmada-bot added the help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. label Jun 2, 2023
@chaunceyjiang
Copy link
Member

Implement deployment of karmada-metrics-adapter using karmadactl.

please assign to @chaunceyjiang .

@jwcesign
Copy link
Member Author

jwcesign commented Jun 2, 2023

please assign to @chaunceyjiang .

Updated in issue content.

@sbdtu5498
Copy link
Contributor

/assign

@jwcesign
Copy link
Member Author

jwcesign commented Jun 4, 2023

Hi, @sbdtu5498 , which part you will do?

@sbdtu5498
Copy link
Contributor

Currently, working on the helm part. But can work on all three.

@jwcesign
Copy link
Member Author

jwcesign commented Jun 5, 2023

Hi, @sbdtu5498 Thanks for your contribution.

@chaunceyjiang will handle the karmadactl portion, so I'll assign the other two parts to you.

@sbdtu5498
Copy link
Contributor

Thanks @jwcesign!

@calvin0327
Copy link

/assign

@jwcesign @sbdtu5498 Can I handle the karmada operator part?

@jwcesign
Copy link
Member Author

jwcesign commented Jun 29, 2023

I am okay with this. Hi @sbdtu5498, if you still do not start, can we delegate this part to @calvin0327?

@sbdtu5498
Copy link
Contributor

Sure @calvin0327 you can work on the operator part.

@jwcesign
Copy link
Member Author

jwcesign commented Jul 17, 2023

/cc @sbdtu5498

Hi, any updates about Helm?

@jwcesign
Copy link
Member Author

Hi, @sbdtu5498 , do you start with the helm part? if not, can we delegate this part to @JadeFlute0127 ?

@sbdtu5498
Copy link
Contributor

@JadeFlute0127 I partially did it some time ago and had it on my local system. I was preoccupied with some other tasks. I will make a PR soon. If possible can you please look for another issue? Thanks!

@sbdtu5498
Copy link
Contributor

#3672 @JadeFlute0127, I didn't get time to work on this one. If you think you can deal with this one, please take a look.

@JadeFlute0127
Copy link
Contributor

@JadeFlute0127 I partially did it some time ago and had it on my local system. I was preoccupied with some other tasks. I will make a PR soon. If possible can you please look for another issue? Thanks!

that's great,thanks for your contribution. i am working for an other issue.

@jwcesign
Copy link
Member Author

jwcesign commented Aug 4, 2023

/cc @sbdtu5498

Hi, did you encounter any issues while implementing the deployment of karmada-metrics-adapter using Helm? We can solve it together

@jwcesign
Copy link
Member Author

Hi @sbdtu5498

Considering that we are planning to release a new version in the near future, I would like to develop this feature firstly and include it in the release.

/assign

@sbdtu5498
Copy link
Contributor

@jwcesign extremely sorry for the delays. I missed the previous email notification and this issue got out of my mind. I had done some preliminary work on the issue and used karmada-search as a reference to do so. If you can provide some review, I will fix it ASAP so that it can be shipped with the next release. Again very sorry for the delays.

@jwcesign
Copy link
Member Author

Thanks, @sbdtu5498 , I will take a look soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
6 participants