-
Notifications
You must be signed in to change notification settings - Fork 909
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
adding helm charts to install karmada metrics adapter #4004
adding helm charts to install karmada metrics adapter #4004
Conversation
Signed-off-by: Sanskar Bhushan <sbdtu5498@gmail.com>
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Codecov Report
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. @@ Coverage Diff @@
## master #4004 +/- ##
==========================================
+ Coverage 54.48% 54.71% +0.22%
==========================================
Files 232 232
Lines 22685 22828 +143
==========================================
+ Hits 12360 12490 +130
- Misses 9648 9659 +11
- Partials 677 679 +2
Flags with carried forward coverage won't be shown. Click here to find out more. |
Hi, @sbdtu5498 Can u help fix the chart lint first? |
Sure I will. Let me take a look. |
app: {{ $name }}-metrics-adapter | ||
apiserver: "true" | ||
spec: | ||
insecureSkipTLSVerify: true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello, thank you for your important commit!
While, we are trying to eliminate insecureSkipTLSVerify=true
in karmada, detail in #4024
Can you refer to karmada-metrics-adapter-apiservice.yaml and #4033 to remove insecureSkipTLSVerify
?
Besides, could you please add steps of "how to verify your code" in this PR?
@sbdtu5498 Do you have a test for this? example: |
Hi, @sbdtu5498 Any updates? |
Thanks for your contribution @sbdtu5498 , we need to release this feature at the end of this month. |
/close |
@RainbowMango: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
What type of PR is this?
/kind feature
What this PR does / why we need it:
Adds helm charts to install karmada metrics adapter
Which issue(s) this PR fixes:
Fixes #3626 helm charts
Does this PR introduce a user-facing change?: