Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding helm charts to install karmada metrics adapter #4004

Closed

Conversation

sbdtu5498
Copy link
Contributor

What type of PR is this?
/kind feature

What this PR does / why we need it:
Adds helm charts to install karmada metrics adapter

Which issue(s) this PR fixes:
Fixes #3626 helm charts

Does this PR introduce a user-facing change?:

NONE

Signed-off-by: Sanskar Bhushan <sbdtu5498@gmail.com>
@karmada-bot karmada-bot added the kind/feature Categorizes issue or PR as related to a new feature. label Aug 25, 2023
@karmada-bot karmada-bot requested review from calvin0327 and pidb August 25, 2023 08:48
@karmada-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign poor12 after the PR has been reviewed.
You can assign the PR to them by writing /assign @poor12 in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@karmada-bot karmada-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Aug 25, 2023
@codecov-commenter
Copy link

Codecov Report

Merging #4004 (d71e88e) into master (fd162b7) will increase coverage by 0.22%.
Report is 2 commits behind head on master.
The diff coverage is n/a.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@            Coverage Diff             @@
##           master    #4004      +/-   ##
==========================================
+ Coverage   54.48%   54.71%   +0.22%     
==========================================
  Files         232      232              
  Lines       22685    22828     +143     
==========================================
+ Hits        12360    12490     +130     
- Misses       9648     9659      +11     
- Partials      677      679       +2     
Flag Coverage Δ
unittests 54.71% <ø> (+0.22%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 4 files with indirect coverage changes

@jwcesign
Copy link
Member

Hi, @sbdtu5498 Can u help fix the chart lint first?

@sbdtu5498
Copy link
Contributor Author

Sure I will. Let me take a look.

app: {{ $name }}-metrics-adapter
apiserver: "true"
spec:
insecureSkipTLSVerify: true
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello, thank you for your important commit!

While, we are trying to eliminate insecureSkipTLSVerify=true in karmada, detail in #4024

Can you refer to karmada-metrics-adapter-apiservice.yaml and #4033 to remove insecureSkipTLSVerify?

Besides, could you please add steps of "how to verify your code" in this PR?

@calvin0327
Copy link

@sbdtu5498 Do you have a test for this? example: helm template or helm install xxx --dry-run

@jwcesign
Copy link
Member

Hi, @sbdtu5498 Any updates?

@jwcesign
Copy link
Member

Thanks for your contribution @sbdtu5498 , we need to release this feature at the end of this month.
I modified based on yours. let‘s follow this in #4303

@RainbowMango
Copy link
Member

/close

@karmada-bot
Copy link
Collaborator

@RainbowMango: Closed this PR.

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: deploy karmada-metreics-adapter with helm/karmadactl/karmada-operator
7 participants