-
Notifications
You must be signed in to change notification settings - Fork 892
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove service accounts for karmada components except for karmada-agent #2523
Conversation
Thanks @carlory , I'll look at it next week. |
I just remember that there is an unusual case where they install Karmada on a cluster and take the |
I don't think we should encourage such usage, because two controllers controlling the same resource, kube-controller-manager and karmada-controller-manager, will conflict when updating state. |
yes. but we should not support this case, right? |
This should be a custom requirement, we can add a doc to describe it. I think that the standard installation method currently doesn't need them. |
Signed-off-by: carlory <baofa.fan@daocloud.io>
Good point. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
Note: I updated the release note a little bit.
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: RainbowMango The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: carlory baofa.fan@daocloud.io
What type of PR is this?
/kind feature
What this PR does / why we need it:
See #2511 (comment)
Which issue(s) this PR fixes:
Part of #2511
Special notes for your reviewer:
Does this PR introduce a user-facing change?: