Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove service accounts for karmada components except for karmada-agent #2523

Merged
merged 1 commit into from
Sep 19, 2022

Conversation

carlory
Copy link
Member

@carlory carlory commented Sep 17, 2022

Signed-off-by: carlory baofa.fan@daocloud.io

What type of PR is this?

/kind feature

What this PR does / why we need it:

See #2511 (comment)

Which issue(s) this PR fixes:
Part of #2511

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

`karmadactl`/`chart`: The `init` no longer creates redundant ServiceAccounts for components except `karmada-agent`.

@karmada-bot karmada-bot added the kind/feature Categorizes issue or PR as related to a new feature. label Sep 17, 2022
@karmada-bot karmada-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Sep 17, 2022
@carlory
Copy link
Member Author

carlory commented Sep 17, 2022

/cc @RainbowMango @lonelyCZ

@RainbowMango
Copy link
Member

Thanks @carlory , I'll look at it next week.

@RainbowMango
Copy link
Member

I just remember that there is an unusual case where they install Karmada on a cluster and take the kube-apiserver as the karmada-apiserver. In that case, does the component needs RBAC?

@carlory
Copy link
Member Author

carlory commented Sep 17, 2022

@RainbowMango

I don't think we should encourage such usage, because two controllers controlling the same resource, kube-controller-manager and karmada-controller-manager, will conflict when updating state.

@carlory
Copy link
Member Author

carlory commented Sep 17, 2022

In that case, does the component needs RBAC?

yes. but we should not support this case, right?

@lonelyCZ
Copy link
Member

In that case, does the component needs RBAC?

This should be a custom requirement, we can add a doc to describe it. I think that the standard installation method currently doesn't need them.

Signed-off-by: carlory <baofa.fan@daocloud.io>
@RainbowMango
Copy link
Member

This should be a custom requirement, we can add a doc to describe it. I think that the standard installation method currently doesn't need them.

Good point.

Copy link
Member

@RainbowMango RainbowMango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

Note: I updated the release note a little bit.

@karmada-bot karmada-bot added the lgtm Indicates that a PR is ready to be merged. label Sep 19, 2022
@karmada-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: RainbowMango

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants