Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add controllers config for karmada-controller-manager #3240

Merged
merged 2 commits into from
Mar 9, 2023

Conversation

Poor12
Copy link
Member

@Poor12 Poor12 commented Mar 6, 2023

What type of PR is this?
/kind cleanup

What this PR does / why we need it:
Add controllers config to karmada-controller-manager.
linked: #2542
Fixes #2542

Which issue(s) this PR fixes:

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

chart: introduce `controllers` config for karmada-controller-manager

@karmada-bot karmada-bot added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label Mar 6, 2023
@karmada-bot karmada-bot requested review from jrkeen and rv64m March 6, 2023 08:22
@karmada-bot karmada-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Mar 6, 2023
Signed-off-by: Poor12 <shentiecheng@huawei.com>
@Poor12 Poor12 force-pushed the helm-controllers branch from 67cd857 to b8c706c Compare March 6, 2023 08:23
@karmada-bot karmada-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 6, 2023
@codecov-commenter
Copy link

Codecov Report

Merging #3240 (b8c706c) into master (eb569ff) will decrease coverage by 0.03%.
The diff coverage is n/a.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##           master    #3240      +/-   ##
==========================================
- Coverage   49.21%   49.18%   -0.03%     
==========================================
  Files         203      203              
  Lines       18354    18354              
==========================================
- Hits         9033     9028       -5     
- Misses       8834     8838       +4     
- Partials      487      488       +1     
Flag Coverage Δ
unittests 49.18% <ø> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/util/worker.go 66.66% <0.00%> (-4.77%) ⬇️
pkg/search/proxy/store/util.go 92.41% <0.00%> (-0.95%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@RainbowMango
Copy link
Member

Please link to the previous PR so that people can get the background as well as the discussions there.

@Poor12
Copy link
Member Author

Poor12 commented Mar 7, 2023

Please link to the previous PR so that people can get the background as well as the discussions there.

Updated.

…nager

Signed-off-by: fredgate <barriere.fr@gmail.com>
@RainbowMango
Copy link
Member

@calvin0327 Do you have any other comments?

Copy link
Member

@RainbowMango RainbowMango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@karmada-bot karmada-bot added the lgtm Indicates that a PR is ready to be merged. label Mar 9, 2023
@karmada-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: RainbowMango

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@karmada-bot karmada-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 9, 2023
@karmada-bot karmada-bot merged commit fa0791e into karmada-io:master Mar 9, 2023
@yanggangtony
Copy link
Member

yanggangtony commented Mar 9, 2023

I have a question , how about the user define controllerManager.config.controllers , controllerManager.controllers
at the same time .

And why retention the 2 parms at the same time ?

@Poor12
@RainbowMango
@calvin0327

@Poor12
Copy link
Member Author

Poor12 commented Mar 9, 2023

I have a question , how about the user define controllerManager.config.controllers , controllerManager.controllers at the same time .

And why retention the 2 parms ?

@Poor12 @RainbowMango @calvin0327

Sorry, I made a mistake. I forgot to delete the config.controllers things when I cherry-pick #2542. Would you like to fix it?

@RainbowMango
Copy link
Member

Thanks @yanggangtony for spotting this, that's my bad for missing it from the review.

@yanggangtony
Copy link
Member

thanks all for the re-check .
😃😃

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants