-
Notifications
You must be signed in to change notification settings - Fork 916
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add controllers config for karmada-controller-manager #3240
Conversation
Signed-off-by: Poor12 <shentiecheng@huawei.com>
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## master #3240 +/- ##
==========================================
- Coverage 49.21% 49.18% -0.03%
==========================================
Files 203 203
Lines 18354 18354
==========================================
- Hits 9033 9028 -5
- Misses 8834 8838 +4
- Partials 487 488 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Please link to the previous PR so that people can get the background as well as the discussions there. |
Updated. |
…nager Signed-off-by: fredgate <barriere.fr@gmail.com>
@calvin0327 Do you have any other comments? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: RainbowMango The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
I have a question , how about the user define And why retention the 2 parms at the same time ? |
Sorry, I made a mistake. I forgot to delete the config.controllers things when I cherry-pick #2542. Would you like to fix it? |
Thanks @yanggangtony for spotting this, that's my bad for missing it from the review. |
thanks all for the re-check . |
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
Add controllers config to karmada-controller-manager.
linked: #2542
Fixes #2542
Which issue(s) this PR fixes:
Special notes for your reviewer:
Does this PR introduce a user-facing change?: