Add controllers config for karmada-controller-manager #3255
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karmada-bot
added
the
kind/cleanup
karmada-bot
added
the
size/XS
|
Would you like to check it in kube-controller-manager together? I'd like to delete the config level. |
yanggangtony
force-pushed
the
helm-controllers
branch
from
24add49 to
ae963d6
Compare
karmada-bot
added
size/S
|
@Poor12 |
Poor12
reviewed
Mar 10, 2023
| @@ -500,7 +496,7 @@ kubeControllerManager: | |||
| rollingUpdate: | |||
| maxUnavailable: 0 | |||
| maxSurge: 50% | |||
|
|
|||
| controllers: namespace,garbagecollector,serviceaccount-token,ttl-after-finished,bootstrapsigner,csrapproving,csrcleaner,csrsigning | |||
There was a problem hiding this comment.
Sorry, I mean add a blank between it and the etcd config.
yanggangtony
force-pushed
the
helm-controllers
branch
from
ae963d6 to
6330d5e
Compare
Signed-off-by: yanggang <gang.yang@daocloud.io>
yanggangtony
force-pushed
the
helm-controllers
branch
from
6330d5e to
ce9df6d
Compare
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Poor12 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
karmada-bot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
Re-check pr fix.
And i found there is a duplicate define for the controllers.
https://github.com/karmada-io/karmada/pull/3240
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?: