Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add validation for MultiClusterIngress #3516

Merged

Conversation

XiShanYongYe-Chang
Copy link
Member

@XiShanYongYe-Chang XiShanYongYe-Chang commented May 10, 2023

What type of PR is this?

/kind feature

What this PR does / why we need it:

add validation for MultiClusterIngress

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

`karmada-webhook`: Inroduced validation for `MultiClusterIngress` objects.

@karmada-bot karmada-bot added the kind/feature Categorizes issue or PR as related to a new feature. label May 10, 2023
@karmada-bot karmada-bot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label May 10, 2023
@XiShanYongYe-Chang XiShanYongYe-Chang force-pushed the add-validation-for-mci branch 3 times, most recently from c3e52c6 to eca6189 Compare May 11, 2023 01:24
@XiShanYongYe-Chang
Copy link
Member Author

/cc @RainbowMango

@XiShanYongYe-Chang
Copy link
Member Author

It works as expected:
image

Copy link
Member

@chaunceyjiang chaunceyjiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#3516

Please keep consistent with this PR.

@XiShanYongYe-Chang
Copy link
Member Author

#3523
@chaunceyjiang Thanks for your remind.

@XiShanYongYe-Chang
Copy link
Member Author

#3516

Please keep consistent with this PR.

Updated~

Signed-off-by: changzhen <changzhen5@huawei.com>
Copy link
Member

@RainbowMango RainbowMango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@karmada-bot karmada-bot added the lgtm Indicates that a PR is ready to be merged. label May 13, 2023
@karmada-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: RainbowMango

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@karmada-bot karmada-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 13, 2023
@karmada-bot karmada-bot merged commit 479b073 into karmada-io:master May 13, 2023
@XiShanYongYe-Chang XiShanYongYe-Chang deleted the add-validation-for-mci branch June 1, 2023 02:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants