Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add missing federatedresourcequota validate config #3523

Merged

Conversation

chaunceyjiang
Copy link
Member

What type of PR is this?
/kind bug

What this PR does / why we need it:

add missing federatedresourcequota validate config

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

https://github.com/karmada-io/karmada/blob/master/artifacts/deploy/webhook-configuration.yaml#L156-L169

Does this PR introduce a user-facing change?:

`karmada-webhook`: add missing federatedresourcequota validate config.

Signed-off-by: chaunceyjiang <chaunceyjiang@gmail.com>
@karmada-bot karmada-bot added the kind/bug Categorizes issue or PR as related to a bug. label May 11, 2023
@karmada-bot karmada-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label May 11, 2023
Copy link
Member

@RainbowMango RainbowMango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Have you tested it?

@karmada-bot karmada-bot added the lgtm Indicates that a PR is ready to be merged. label May 11, 2023
Copy link
Member

@XiShanYongYe-Chang XiShanYongYe-Chang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unable to modify with the current pr, I found that we have some of the wrong names on the file,

mainfests -> manifests

@RainbowMango
Copy link
Member

Unable to modify with the current pr, I found that we have some of the wrong names on the file,

mainfests -> manifests

cc operator owners here: @calvin0327 @Poor12
operator/pkg/karmadaresource/webhookconfiguration/mainfests.go.

@calvin0327
Copy link

I will test it tomorrow

@RainbowMango
Copy link
Member

I will test it tomorrow

Please don't get me wrong, I didn't mean to ask you to test this PR, I mean we might need to fix the typo in the file name, that should be done by another PR.

@calvin0327
Copy link

I will test it tomorrow

Please don't get me wrong, I didn't mean to ask you to test this PR, I mean we might need to fix the typo in the file name, that should be done by another PR.

yes, the file name mainfests is typo, I will fix it in another PR.

@chaunceyjiang
Copy link
Member Author

Unable to modify with the current pr, I found that we have some of the wrong names on the file,

mainfests -> manifests

This is a very good good-first-issue. Could you help create a issue with a label good-first-issue ? @calvin0327

@chaunceyjiang
Copy link
Member Author

Have you tested it?

Yes. Tested Karmadactl

Copy link
Member

@RainbowMango RainbowMango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@karmada-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: RainbowMango

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@karmada-bot karmada-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 12, 2023
@karmada-bot karmada-bot merged commit 772f89a into karmada-io:master May 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants