-
Notifications
You must be signed in to change notification settings - Fork 918
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: add missing federatedresourcequota validate config #3523
fix: add missing federatedresourcequota validate config #3523
Conversation
Signed-off-by: chaunceyjiang <chaunceyjiang@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
Have you tested it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unable to modify with the current pr, I found that we have some of the wrong names on the file,
mainfests
-> manifests
cc operator owners here: @calvin0327 @Poor12 |
I will test it tomorrow |
Please don't get me wrong, I didn't mean to ask you to test this PR, I mean we might need to fix the typo in the file name, that should be done by another PR. |
yes, the file name |
This is a very good |
Yes. Tested Karmadactl |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: RainbowMango The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind bug
What this PR does / why we need it:
add missing federatedresourcequota validate config
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
https://github.com/karmada-io/karmada/blob/master/artifacts/deploy/webhook-configuration.yaml#L156-L169
Does this PR introduce a user-facing change?: