Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update karmada operator default karmada version #3718

Merged

Conversation

learner0810
Copy link
Member

@learner0810 learner0810 commented Jun 27, 2023

What type of PR is this?

/kind feature

What this PR does / why we need it:

Which issue(s) this PR fixes:

[root@master-01 ~]# k -n test get karmada.operator.karmada.io/karmada-demo -oyaml
apiVersion: operator.karmada.io/v1alpha1
kind: Karmada
metadata:
  creationTimestamp: "2023-06-27T07:12:57Z"
  finalizers:
  - operator.karmada.io/finalizer
  generation: 2
  labels:
    operator.karmada.io/disable-cascading-deletion: "false"
  name: karmada-demo
  namespace: test
  resourceVersion: "746734041"
  uid: 423ea5fe-b848-4b5f-b51a-aaeed83b6ea7
spec:
  components:
    etcd:
      local:
        imageRepository: registry.k8s.io/etcd
        imageTag: 3.5.3-0
        replicas: 1
        resources: {}
        volumeData:
          volumeClaim:
            metadata: {}
            spec:
              accessModes:
              - ReadWriteOnce
              resources:
                requests:
                  storage: 3Gi
    karmadaAPIServer:
      imageRepository: registry.k8s.io/kube-apiserver
      imageTag: v1.25.4
      replicas: 1
      resources: {}
      serviceSubnet: 10.96.0.0/12
      serviceType: NodePort
    karmadaAggregatedAPIServer:
      imageRepository: docker.io/karmada/karmada-aggregated-apiserver
      imageTag: v1.6.0
      replicas: 1
      resources: {}
    karmadaControllerManager:
      imageRepository: docker.io/karmada/karmada-controller-manager
      imageTag: v1.6.0
      replicas: 1
      resources: {}
    karmadaScheduler:
      imageRepository: docker.io/karmada/karmada-scheduler
      imageTag: v1.6.0
      replicas: 1
      resources: {}
    karmadaWebhook:
      imageRepository: docker.io/karmada/karmada-webhook
      imageTag: v1.6.0
      replicas: 1
      resources: {}
    kubeControllerManager:
      imageRepository: registry.k8s.io/kube-controller-manager
      imageTag: v1.25.4
      replicas: 1
      resources: {}
  hostCluster:
    networking:
      dnsDomain: cluster.local


[root@master-01 ~]# k -n test get pod
NAME                                                    READY   STATUS    RESTARTS      AGE
karmada-demo-aggregated-apiserver-5544c5d8b7-gqjsf      1/1     Running   0             6m9s
karmada-demo-apiserver-d66dd9cb-sn4kw                   1/1     Running   0             9m
karmada-demo-controller-manager-6858bf649d-t67qd        1/1     Running   0             5m5s
karmada-demo-etcd-0                                     1/1     Running   0             9m16s
karmada-demo-kube-controller-manager-74575bbcdc-nf5jk   1/1     Running   2 (36s ago)   5m5s
karmada-demo-scheduler-7b7c7b5649-4tr4z                 1/1     Running   0             5m4s
karmada-demo-webhook-c646bc69d-dgxv2                    1/1     Running   0             5m4s

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

@karmada-bot karmada-bot added the kind/feature Categorizes issue or PR as related to a new feature. label Jun 27, 2023
@karmada-bot karmada-bot requested review from lonelyCZ and Poor12 June 27, 2023 07:31
@karmada-bot karmada-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jun 27, 2023
@codecov-commenter
Copy link

Codecov Report

Merging #3718 (81bba75) into master (b005d5b) will increase coverage by 0.00%.
The diff coverage is n/a.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@           Coverage Diff           @@
##           master    #3718   +/-   ##
=======================================
  Coverage   55.68%   55.69%           
=======================================
  Files         222      222           
  Lines       21195    21195           
=======================================
+ Hits        11803    11805    +2     
+ Misses       8765     8763    -2     
  Partials      627      627           
Flag Coverage Δ
unittests 55.69% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 1 file with indirect coverage changes

Signed-off-by: learner0810 <zhongjun.li@daocloud.io>
@learner0810 learner0810 force-pushed the update-karmada-default-Version branch from 81bba75 to df110d2 Compare June 27, 2023 07:49
@calvin0327
Copy link

/assign

@calvin0327
Copy link

Please update title, It is prone to doubts.

@learner0810 learner0810 changed the title update-karmada-default-Version update karmada operator default karmada version Jun 28, 2023
@calvin0327
Copy link

thanks.
/lgtm

@Poor12 @lonelyCZ PTAL

@karmada-bot karmada-bot added the lgtm Indicates that a PR is ready to be merged. label Jun 28, 2023
@Poor12
Copy link
Member

Poor12 commented Jun 28, 2023

/approve

@karmada-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Poor12

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@karmada-bot karmada-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 28, 2023
@karmada-bot karmada-bot merged commit 741ff43 into karmada-io:master Jun 28, 2023
@learner0810 learner0810 deleted the update-karmada-default-Version branch June 30, 2023 09:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants