Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: karmada-operator install default version karmada #4133

Merged
merged 1 commit into from
Oct 24, 2023

Conversation

chaosi-zju
Copy link
Member

@chaosi-zju chaosi-zju commented Oct 13, 2023

What type of PR is this?

/kind feature

What this PR does / why we need it:

operator can judge which version karmada to install by operator itself's image version, inteaed of using fixed version in constant variable. (so, we will no longger need to manually submit PR like #3718)

Which issue(s) this PR fixes:

Special notes for your reviewer:

how to test it:

#!/bin/bash

kind delete clusters --all; rm -rf ~/.karmada/; rm -rf ~/.kube/*.config; rm -rf /etc/karmada
cd path/to/karmada  # clone my submited code, and cd to your karmada repo path

hack/create-cluster.sh karmada-host ~/.kube/karmada-host.config
export KUBECONFIG=~/.kube/karmada-host.config

export VERSION="latest"
export REGISTRY="docker.io/karmada"
make image-karmada-operator GOOS="linux" --directory=.

kind load docker-image docker.io/karmada/karmada-operator:latest --name karmada-host
kind load docker-image registry.k8s.io/etcd:3.5.9-0 --name karmada-host
kind load docker-image registry.k8s.io/kube-apiserver:v1.25.4 --name karmada-host
kind load docker-image registry.k8s.io/kube-controller-manager:v1.25.4 --name karmada-host

helm install karmada-operator -n karmada-system  --create-namespace --dependency-update ./charts/karmada-operator --debug

kubectl apply -f operator/config/crds/

read -s -n1 -p "Press any key to continue ... "

cat >/tmp/karmada.yaml<<EOF
apiVersion: operator.karmada.io/v1alpha1
kind: Karmada
metadata:
  name: karmada
  namespace: karmada-system
EOF
kubectl apply -f karmada.yaml

test report:
image
image
image

Does this PR introduce a user-facing change?:

`karmada-operator`: The default installed version of Karmada now depends on the operator version.

@karmada-bot karmada-bot added the kind/bug Categorizes issue or PR as related to a bug. label Oct 13, 2023
@karmada-bot karmada-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Oct 13, 2023
@calvin0327
Copy link

/assign

@calvin0327
Copy link

@chaosi-zju Thanks, this is a good feature for operator. and this pr has some conflicts.

@chaosi-zju
Copy link
Member Author

@chaosi-zju Thanks, this is a good feature for operator. and this pr has some conflicts.

ok, I am fixing it~

@codecov-commenter
Copy link

codecov-commenter commented Oct 16, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (920f5bf) 52.99% compared to head (3347746) 53.00%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #4133   +/-   ##
=======================================
  Coverage   52.99%   53.00%           
=======================================
  Files         239      239           
  Lines       23536    23536           
=======================================
+ Hits        12473    12475    +2     
+ Misses      10381    10379    -2     
  Partials      682      682           
Flag Coverage Δ
unittests 53.00% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@chaosi-zju chaosi-zju force-pushed the dev-operator branch 2 times, most recently from 56ce05c to 29875b7 Compare October 21, 2023 09:29
@chaosi-zju
Copy link
Member Author

I have rebased master again, ready to review ~

Copy link
Member

@RainbowMango RainbowMango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally looks good, just a nit.

operator/config/samples/karmada.yaml Outdated Show resolved Hide resolved
Signed-off-by: chaosi-zju <chaosi@zju.edu.cn>
Copy link
Member

@RainbowMango RainbowMango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@karmada-bot karmada-bot added the lgtm Indicates that a PR is ready to be merged. label Oct 24, 2023
@karmada-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: RainbowMango

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@karmada-bot karmada-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 24, 2023
@karmada-bot karmada-bot merged commit 0fe6f14 into karmada-io:master Oct 24, 2023
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants