-
Notifications
You must be signed in to change notification settings - Fork 892
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: karmada-operator install default version karmada #4133
Conversation
/assign |
@chaosi-zju Thanks, this is a good feature for operator. and this pr has some conflicts. |
ok, I am fixing it~ |
db10984
to
72900c6
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #4133 +/- ##
=======================================
Coverage 52.99% 53.00%
=======================================
Files 239 239
Lines 23536 23536
=======================================
+ Hits 12473 12475 +2
+ Misses 10381 10379 -2
Partials 682 682
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
56ce05c
to
29875b7
Compare
I have rebased master again, ready to review ~ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generally looks good, just a nit.
Signed-off-by: chaosi-zju <chaosi@zju.edu.cn>
29875b7
to
3347746
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: RainbowMango The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind feature
What this PR does / why we need it:
operator can judge which version karmada to install by operator itself's image version, inteaed of using fixed version in constant variable. (so, we will no longger need to manually submit PR like #3718)
Which issue(s) this PR fixes:
Special notes for your reviewer:
how to test it:
test report:
Does this PR introduce a user-facing change?: