-
Notifications
You must be signed in to change notification settings - Fork 909
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
local up install karmada by helm #4045
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #4045 +/- ##
=======================================
Coverage 46.30% 46.30%
=======================================
Files 663 663
Lines 54753 54753
=======================================
+ Hits 25351 25352 +1
+ Misses 27774 27773 -1
Partials 1628 1628
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
@RainbowMango comments all resolved~ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Other lgtm
1d89aa8
to
3b49677
Compare
bf4bc1b
to
a23bb65
Compare
231ab96
to
31960b9
Compare
@jwcesign have a look again~ |
5842759
to
97eb5d2
Compare
CC @RainbowMango ready to merge by this PR, we can install current code by helm method in CI |
d54b9a1
to
d49c03a
Compare
5b1d9cc
to
d94f6d3
Compare
/lgtm |
@chaosi-zju I'm looking at this PR, can you help to rebase this to make CI happy? |
Signed-off-by: chaosi-zju <chaosi@zju.edu.cn>
New changes are detected. LGTM label has been removed. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@RainbowMango done, and this task has finished as expected: https://github.com/karmada-io/karmada/actions/runs/12064914211/job/33642639899?pr=4045 |
For the benefits of this PR, I have commented on #4305 (comment), which seems not based on a real use case to me. What I'm looking for is the solution for #5436. |
/close |
@RainbowMango: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
What type of PR is this?
/kind feature
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #4305
Special notes for your reviewer:
hack/local-up-karmada-helm.sh
as:then, provided your given cluster name and kubeconfig just like:
Execute the script:
You will see:
Does this PR introduce a user-facing change?: