-
Notifications
You must be signed in to change notification settings - Fork 909
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
resourceModels supports extended resources #4307
Conversation
b08b6a7
to
9168818
Compare
Codecov ReportAttention:
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #4307 +/- ##
==========================================
- Coverage 52.00% 51.99% -0.01%
==========================================
Files 242 242
Lines 23993 23977 -16
==========================================
- Hits 12478 12468 -10
+ Misses 10834 10829 -5
+ Partials 681 680 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Signed-off-by: chaosi-zju <chaosi@zju.edu.cn>
I have carefully tested this feature, it is ok. Is there any further comments? If you have any other suggestions, please let me know~ |
Ok, thanks~ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
@chaunceyjiang Do you have any further comment?
Test report updated |
LGTM. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
I updated the release note by the way.
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: chaunceyjiang, RainbowMango The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind feature
What this PR does / why we need it:
resourceModels supports extended resources
Which issue(s) this PR fixes:
Fixes #4050
Special notes for your reviewer:
Demo:https://h3ld32xlpo.feishu.cn/wiki/Rj5mwS3TCigHY4kMKzhcqTggnlg
Test Steps:
member1
cluster has three nodes)# modify the NEED_CREATE_KIND_CLUSTER=false, and IMAGE_FROM=make hack/local-up-karmada-helm.sh
karmada.io/gpu
by the method described in my Demothen
member1
will have 3 nodes, each node have 3karmada.io/gpu
, 9 in totaland
member2
will have 1 node, with 5karmada.io/gpu
, 5 in totalyou can see
cluster.cluster.karmada.io/member1 patched
, which means the resource model ofkarmada.io/gpu
applied.then you will see the
resourceSummary
of cluster object updated:in the cluster object of
member1
:in the cluster object of
member2
:karmada.io/gpu
, described in my Demothen it will be assign to
member2
cluster, which is just as expected.though
member1
cluster has 9karmada.io/gpu
, none of its nodes satisfy the requirement, so onlymember2
is able to deploy that pod.Does this PR introduce a user-facing change?: