fix: cannot access ResourceRegistry with its singularName

[zhzhuang-zju]

What type of PR is this?

What this PR does / why we need it:
Referring to #4141
we cannot access resource ResourceRegistry with its singularName.

Which issue(s) this PR fixes:
Fixes #4141

Special notes for your reviewer:
none

Does this PR introduce a user-facing change?:

`karmada-search`: Fixed can not access ResourceRegistry issue due to misconfigured singular name.

[codecov-commenter]

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (557348f) 53.48% compared to head (61302b5) 53.48%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

@@           Coverage Diff           @@
##           master    #4144   +/-   ##
=======================================
  Coverage   53.48%   53.48%           
=======================================
  Files         234      234           
  Lines       23304    23304           
=======================================
  Hits        12465    12465           
- Misses      10157    10158    +1     
+ Partials      682      681    -1     

Flag	Coverage Δ
unittests	53.48% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files	Coverage Δ
pkg/registry/search/storage/resourceregistry.go	0.00% <0.00%> (ø)

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[XiShanYongYe-Chang]

Can you help post your test report?

[zhzhuang-zju]

Can you help post your test report?

Certainly!

➜  karmada git:(master) ✗ kubectl --kubeconfig $HOME/.kube/karmada.config --context karmada-apiserver get ResourceRegistry
NAME                CREATED AT
deployment-search   2023-10-17T11:40:36Z
➜  karmada git:(master) ✗ kubectl --kubeconfig $HOME/.kube/karmada.config --context karmada-apiserver get resourceregistries
NAME                CREATED AT
deployment-search   2023-10-17T11:40:36Z

Executing kubectl get resourceregisty runs as well as executing kubectl get resourceregistries.

[XiShanYongYe-Chang]

Thanks a lot~
/lgtm
/approve

[karmada-bot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: XiShanYongYe-Chang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• pkg/registry/OWNERS [XiShanYongYe-Chang]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[XiShanYongYe-Chang]

We need to cherry-pick this patch to the previous branch, I will create an issue to track this.

[RainbowMango]

@zhzhuang-zju Have you ever thought about if this patch would block the upgrade?
For example, there is a ResourceRegistry resource that was created in the previous version, like v1.7.0, I'm not sure if there is a problem when upgrading the karmada-aggregated-apiserver.

Can you help to confirm that?

[zhzhuang-zju]

Nice finding! It is necessary to verify the upgrade scenario, and I‘d like to confirm it.

[zhzhuang-zju]

I did some experiments and found that there is indeed a problem in the upgrade scenario.
Specific steps are as follows，

1. use version release-1.7.0 to build the karmada environment
2. Create ResourceRegistry with command kubectl --kubeconfig $HOME/.kube/karmada.config --context karmada-apiserver create -f deployment-search.yaml

### deployment-search.yaml
apiVersion: search.karmada.io/v1alpha1
kind: ResourceRegistry
metadata:
  name: deployment-search
spec:
  targetCluster:
    clusterNames:
      - member1
      - member2
  resourceSelectors:
    - apiVersion: apps/v1
      kind: Deployment

3.Execute kubectl --kubeconfig $HOME/.kube/karmada.config --context karmada-apiserver get ResourceRegistry

➜  templates kubectl --kubeconfig $HOME/.kube/karmada.config --context karmada-apiserver get ResourceRegistry
error: the server doesn't have a resource type "ResourceRegistry"

4.Upgrade the component karmada-search with the latest image.
5.Execute kubectl --kubeconfig $HOME/.kube/karmada.config --context karmada-apiserver get ResourceRegistry

➜  karmada git:(master) ✗ kubectl --kubeconfig $HOME/.kube/karmada.config --context karmada-apiserver get ResourceRegistry
No resources found

It seems that it can't find the resource with kind: ResourceRegistry that was released before the upgrade.
In addition, I found that when the code in line 31 of file pkg/registry/search/storage/resourceregistry.go is changed to DefaultQualifiedResource: searchapis.Resource("resourceRegistries"),, the upgrade problem seems to be solved.

➜  karmada git:(master) ✗ kubectl --kubeconfig $HOME/.kube/karmada.config --context karmada-apiserver get ResourceRegistry  
NAME                CREATED AT
deployment-search   2023-10-21T11:20:04Z
➜  karmada git:(master) ✗ kubectl --kubeconfig $HOME/.kube/karmada.config --context karmada-apiserver get resourceregistries
NAME                CREATED AT
deployment-search   2023-10-21T11:20:04Z