Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automated cherry pick of #4144: fix: cannot access ResourceRegistry with its singularName #4153

Conversation

Yan-Daojiang
Copy link
Contributor

@Yan-Daojiang Yan-Daojiang commented Oct 20, 2023

Cherry pick of #4144 on release-1.7.
#4144: fix: cannot access ResourceRegistry with its singularName
For details on the cherry pick process, see the cherry pick requests page.

`karmada-search`: Fixed can not access ResourceRegistry issue due to misconfigured singular name.

Signed-off-by: zhzhuang-zju <m17799853869@163.com>
@karmada-bot karmada-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Oct 20, 2023
@codecov-commenter
Copy link

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (c6e7cf9) 53.86% compared to head (57e972a) 53.86%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff              @@
##           release-1.7    #4153   +/-   ##
============================================
  Coverage        53.86%   53.86%           
============================================
  Files              231      231           
  Lines            22949    22949           
============================================
  Hits             12361    12361           
  Misses            9920     9920           
  Partials           668      668           
Flag Coverage Δ
unittests 53.86% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
pkg/registry/search/storage/resourceregistry.go 0.00% <0.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@RainbowMango RainbowMango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@karmada-bot karmada-bot added the lgtm Indicates that a PR is ready to be merged. label Oct 21, 2023
@karmada-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: RainbowMango

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@karmada-bot karmada-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 21, 2023
@karmada-bot karmada-bot merged commit 7ffcd18 into karmada-io:release-1.7 Oct 21, 2023
12 checks passed
@Yan-Daojiang Yan-Daojiang deleted the automated-cherry-pick-of-#4144-upstream-release-1.7 branch October 21, 2023 03:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants