Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: add proposal for mcs with native service name #4287

Conversation

jwcesign
Copy link
Member

@jwcesign jwcesign commented Nov 21, 2023

What type of PR is this?
/kind documentation

What this PR does / why we need it:
doc: add proposal for mcs with native service name

Which issue(s) this PR fixes:
Part of #4292

Special notes for your reviewer:
none

Does this PR introduce a user-facing change?:


@karmada-bot karmada-bot added the kind/documentation Categorizes issue or PR as related to documentation. label Nov 21, 2023
@karmada-bot karmada-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Nov 21, 2023
@codecov-commenter
Copy link

codecov-commenter commented Nov 21, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (8626902) 52.79% compared to head (a0c80ee) 52.00%.
Report is 38 commits behind head on master.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4287      +/-   ##
==========================================
- Coverage   52.79%   52.00%   -0.80%     
==========================================
  Files         240      242       +2     
  Lines       23624    23984     +360     
==========================================
  Hits        12473    12473              
- Misses      10472    10830     +358     
- Partials      679      681       +2     
Flag Coverage Δ
unittests 52.00% <ø> (-0.80%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jwcesign jwcesign force-pushed the added-K8s-native-implementation-details branch from b927625 to cb6d424 Compare November 21, 2023 01:39
docs/proposals/service-discovery/README.md Outdated Show resolved Hide resolved
docs/proposals/service-discovery/README.md Outdated Show resolved Hide resolved
docs/proposals/service-discovery/README.md Outdated Show resolved Hide resolved
docs/proposals/service-discovery/README.md Outdated Show resolved Hide resolved
docs/proposals/service-discovery/README.md Show resolved Hide resolved
@jwcesign jwcesign force-pushed the added-K8s-native-implementation-details branch from cb6d424 to cafaa26 Compare November 21, 2023 02:02
@karmada-bot karmada-bot added the do-not-merge/contains-merge-commits Indicates a PR which contains merge commits. label Nov 21, 2023
@jwcesign jwcesign force-pushed the added-K8s-native-implementation-details branch from cafaa26 to f00926b Compare November 21, 2023 02:03
@karmada-bot karmada-bot removed the do-not-merge/contains-merge-commits Indicates a PR which contains merge commits. label Nov 21, 2023
@jwcesign jwcesign force-pushed the added-K8s-native-implementation-details branch from f00926b to 4ca735c Compare November 21, 2023 06:26
@jwcesign jwcesign force-pushed the added-K8s-native-implementation-details branch from 4ca735c to 9c1fe02 Compare November 21, 2023 08:54
Signed-off-by: jwcesign <jwcesign@gmail.com>
@jwcesign jwcesign force-pushed the added-K8s-native-implementation-details branch from 9c1fe02 to a0c80ee Compare November 29, 2023 08:32
Copy link
Member

@RainbowMango RainbowMango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@karmada-bot karmada-bot added the lgtm Indicates that a PR is ready to be merged. label Nov 29, 2023
@karmada-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: RainbowMango

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@karmada-bot karmada-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 29, 2023
@karmada-bot karmada-bot merged commit 01b086d into karmada-io:master Nov 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/documentation Categorizes issue or PR as related to documentation. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants