-
Notifications
You must be signed in to change notification settings - Fork 920
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc: add proposal for mcs with native service name #4287
doc: add proposal for mcs with native service name #4287
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #4287 +/- ##
==========================================
- Coverage 52.79% 52.00% -0.80%
==========================================
Files 240 242 +2
Lines 23624 23984 +360
==========================================
Hits 12473 12473
- Misses 10472 10830 +358
- Partials 679 681 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
b927625
to
cb6d424
Compare
cb6d424
to
cafaa26
Compare
cafaa26
to
f00926b
Compare
f00926b
to
4ca735c
Compare
4ca735c
to
9c1fe02
Compare
Signed-off-by: jwcesign <jwcesign@gmail.com>
9c1fe02
to
a0c80ee
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: RainbowMango The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind documentation
What this PR does / why we need it:
doc: add proposal for mcs with native service name
Which issue(s) this PR fixes:
Part of #4292
Special notes for your reviewer:
none
Does this PR introduce a user-facing change?: